Skip to content

[M68k] Add support for bitwise NOT instruction #88049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[M68k] Add support for bitwise NOT instruction #88049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9552a6
[M68k] Add support for bitwise NOT instruction
n8pjl Apr 8, 2024
b16ac80
Add MC testcases for M68k bitwise not
n8pjl Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions llvm/lib/Target/M68k/M68kInstrArithmetic.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
/// ADD [~] ADDA [~] ADDI [~] ADDQ [ ] ADDX [~]
/// CLR [ ] CMP [~] CMPA [~] CMPI [~] CMPM [ ]
/// CMP2 [ ] DIVS/DIVU [~] DIVSL/DIVUL [ ] EXT [~] EXTB [ ]
/// MULS/MULU [~] NEG [~] NEGX [~] SUB [~] SUBA [~]
/// SUBI [~] SUBQ [ ] SUBX [~]
/// MULS/MULU [~] NEG [~] NEGX [~] NOT [~] SUB [~]
/// SUBA [~] SUBI [~] SUBQ [ ] SUBX [~]
///
/// Map:
///
Expand Down Expand Up @@ -769,7 +769,7 @@ def : Pat<(mulhu i16:$dst, Mxi16immSExt16:$opd),


//===----------------------------------------------------------------------===//
// NEG/NEGX
// NEG/NEGX/NOT
//===----------------------------------------------------------------------===//

/// ------------+------------+------+---------+---------
Expand Down Expand Up @@ -809,12 +809,26 @@ class MxNegX_D<MxType TYPE>
}
}

class MxNot_D<MxType TYPE>
: MxInst<(outs TYPE.ROp:$dst), (ins TYPE.ROp:$src),
"not."#TYPE.Prefix#"\t$dst",
[(set TYPE.VT:$dst, (not TYPE.VT:$src))]> {
let Inst = (descend 0b01000110,
/*SIZE*/!cast<MxEncSize>("MxEncSize"#TYPE.Size).Value,
//MODE without last bit
0b00,
//REGISTER prefixed by D/A bit
(operand "$dst", 4)
);
}

} // let Constraints
} // let Defs = [CCR]

foreach S = [8, 16, 32] in {
def NEG#S#d : MxNeg_D<!cast<MxType>("MxType"#S#"d")>;
def NEGX#S#d : MxNegX_D<!cast<MxType>("MxType"#S#"d")>;
def NOT#S#d : MxNot_D<!cast<MxType>("MxType"#S#"d")>;
}

def : Pat<(MxSub 0, i8 :$src), (NEG8d MxDRD8 :$src)>;
Expand Down
86 changes: 86 additions & 0 deletions llvm/test/CodeGen/M68k/Arith/unary.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --filter-out ";*\.cfi_*"
; RUN: llc < %s -mtriple=m68k-linux -verify-machineinstrs | FileCheck %s

define i64 @notll(i64 %x) {
; CHECK-LABEL: notll:
; CHECK: ; %bb.0:
; CHECK: move.l (4,%sp), %d0
; CHECK: not.l %d0
; CHECK: move.l (8,%sp), %d1
; CHECK: not.l %d1
; CHECK: rts
%not = xor i64 %x, -1
ret i64 %not
}

define i32 @notl(i32 %x) {
; CHECK-LABEL: notl:
; CHECK: ; %bb.0:
; CHECK: move.l (4,%sp), %d0
; CHECK: not.l %d0
; CHECK: rts
%not = xor i32 %x, -1
ret i32 %not
}

define i16 @nots(i16 %x) {
; CHECK-LABEL: nots:
; CHECK: ; %bb.0:
; CHECK: move.w (6,%sp), %d0
; CHECK: not.w %d0
; CHECK: rts
%not = xor i16 %x, -1
ret i16 %not
}

define i8 @notb(i8 %x) {
; CHECK-LABEL: notb:
; CHECK: ; %bb.0:
; CHECK: move.b (7,%sp), %d0
; CHECK: not.b %d0
; CHECK: rts
%not = xor i8 %x, -1
ret i8 %not
}

define i64 @negll(i64 %x) {
; CHECK-LABEL: negll:
; CHECK: ; %bb.0:
; CHECK: move.l (4,%sp), %d0
; CHECK: move.l (8,%sp), %d1
; CHECK: neg.l %d1
; CHECK: negx.l %d0
; CHECK: rts
%neg = sub i64 0, %x
ret i64 %neg
}

define i32 @negl(i32 %x) {
; CHECK-LABEL: negl:
; CHECK: ; %bb.0:
; CHECK: move.l (4,%sp), %d0
; CHECK: neg.l %d0
; CHECK: rts
%neg = sub i32 0, %x
ret i32 %neg
}

define i16 @negs(i16 %x) {
; CHECK-LABEL: negs:
; CHECK: ; %bb.0:
; CHECK: move.w (6,%sp), %d0
; CHECK: neg.w %d0
; CHECK: rts
%neg = sub i16 0, %x
ret i16 %neg
}

define i8 @negb(i8 %x) {
; CHECK-LABEL: negb:
; CHECK: ; %bb.0:
; CHECK: move.b (7,%sp), %d0
; CHECK: neg.b %d0
; CHECK: rts
%neg = sub i8 0, %x
ret i8 %neg
}
2 changes: 1 addition & 1 deletion llvm/test/CodeGen/M68k/Atomics/rmw.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ define i16 @atmoicrmw_nand_i16(i16 %val, ptr %ptr) {
; ATOMIC-NEXT: ; =>This Inner Loop Header: Depth=1
; ATOMIC-NEXT: move.w %d2, %d3
; ATOMIC-NEXT: and.w %d0, %d3
; ATOMIC-NEXT: eori.w #-1, %d3
; ATOMIC-NEXT: not.w %d3
; ATOMIC-NEXT: cas.w %d1, %d3, (%a0)
; ATOMIC-NEXT: move.w %d1, %d3
; ATOMIC-NEXT: sub.w %d2, %d3
Expand Down
6 changes: 6 additions & 0 deletions llvm/test/MC/Disassembler/M68k/arithmetic.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@
# CHECK: negx.l %a2
0x40 0x8a

# CHECK: not.l %d5
0x46 0x85

# CHECK: not.b %d1
0x46 0x01

# CHECK: or.w (18,%a4,%a0), %d3
0x86 0x74 0x88 0x12

Expand Down
11 changes: 11 additions & 0 deletions llvm/test/MC/M68k/Arith/Classes/MxNOT.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
; RUN: llvm-mc -triple=m68k -show-encoding %s | FileCheck %s

; CHECK: not.b %d0
; CHECK-SAME: encoding: [0x46,0x00]
not.b %d0
; CHECK: not.w %d0
; CHECK-SAME: encoding: [0x46,0x40]
not.w %d0
; CHECK: not.l %d0
; CHECK-SAME: encoding: [0x46,0x80]
not.l %d0