[HWASAN][UBSAN] Reverse random logic #88070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
|
@llvm/pr-subscribers-compiler-rt-sanitizer @llvm/pr-subscribers-llvm-transforms Author: Vitaly Buka (vitalybuka) ChangesIt feels more intuitive to make higher P to keep more checks. Full diff: https://github.com/llvm/llvm-project/pull/88070.diff 4 Files Affected:
diff --git a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
index ad1cd9c1f6bf12..82f60f4feed454 100644
--- a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
+++ b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
@@ -186,9 +186,9 @@ static cl::opt<int> ClHotPercentileCutoff("hwasan-percentile-cutoff-hot",
cl::desc("Hot percentile cuttoff."));
static cl::opt<float>
- ClRandomSkipRate("hwasan-random-skip-rate",
+ ClRandomSkipRate("hwasan-random-rate",
cl::desc("Probability value in the range [0.0, 1.0] "
- "to skip instrumentation of a function."));
+ "to keep instrumentation of a function."));
STATISTIC(NumTotalFuncs, "Number of total funcs");
STATISTIC(NumInstrumentedFuncs, "Number of instrumented funcs");
@@ -1496,7 +1496,7 @@ bool HWAddressSanitizer::selectiveInstrumentationShouldSkip(
Function &F, FunctionAnalysisManager &FAM) const {
if (ClRandomSkipRate.getNumOccurrences()) {
std::bernoulli_distribution D(ClRandomSkipRate);
- return (D(*Rng));
+ return !D(*Rng);
}
if (!ClHotPercentileCutoff.getNumOccurrences())
return false;
diff --git a/llvm/lib/Transforms/Instrumentation/LowerAllowCheckPass.cpp b/llvm/lib/Transforms/Instrumentation/LowerAllowCheckPass.cpp
index 54b63278e9dd9f..cdc8318f088c27 100644
--- a/llvm/lib/Transforms/Instrumentation/LowerAllowCheckPass.cpp
+++ b/llvm/lib/Transforms/Instrumentation/LowerAllowCheckPass.cpp
@@ -30,7 +30,7 @@ static cl::opt<int>
static cl::opt<float>
RandomRate("lower-allow-check-random-rate",
cl::desc("Probability value in the range [0.0, 1.0] of "
- "unconditional pseudo-random checks removal."));
+ "unconditional pseudo-random checks."));
STATISTIC(NumChecksTotal, "Number of checks");
STATISTIC(NumChecksRemoved, "Number of removed checks");
@@ -48,7 +48,7 @@ static bool removeUbsanTraps(Function &F, const BlockFrequencyInfo &BFI,
if (!Rng)
Rng = F.getParent()->createRNG(F.getName());
std::bernoulli_distribution D(RandomRate);
- return D(*Rng);
+ return !D(*Rng);
};
for (BasicBlock &BB : F) {
diff --git a/llvm/test/Instrumentation/HWAddressSanitizer/pgo-opt-out.ll b/llvm/test/Instrumentation/HWAddressSanitizer/pgo-opt-out.ll
index ab3f56dbee9e7c..f2661a02da7a07 100644
--- a/llvm/test/Instrumentation/HWAddressSanitizer/pgo-opt-out.ll
+++ b/llvm/test/Instrumentation/HWAddressSanitizer/pgo-opt-out.ll
@@ -1,7 +1,7 @@
; RUN: opt < %s -passes='require<profile-summary>,hwasan' -S -hwasan-percentile-cutoff-hot=700000 | FileCheck %s --check-prefix=HOT70
; RUN: opt < %s -passes='require<profile-summary>,hwasan' -S -hwasan-percentile-cutoff-hot=990000 | FileCheck %s --check-prefix=HOT99
-; RUN: opt < %s -passes='require<profile-summary>,hwasan' -S -hwasan-random-skip-rate=0.0 | FileCheck %s --check-prefix=RANDOM0
-; RUN: opt < %s -passes='require<profile-summary>,hwasan' -S -hwasan-random-skip-rate=1.0 | FileCheck %s --check-prefix=RANDOM1
+; RUN: opt < %s -passes='require<profile-summary>,hwasan' -S -hwasan-random-rate=1.0 | FileCheck %s --check-prefix=ALL
+; RUN: opt < %s -passes='require<profile-summary>,hwasan' -S -hwasan-random-rate=0.0 | FileCheck %s --check-prefix=NONE
; HOT70: @sanitized
; HOT70-NEXT: @__hwasan_tls
@@ -9,11 +9,11 @@
; HOT99: @sanitized
; HOT99-NEXT: %x = alloca i8, i64 4
-; RANDOM0: @sanitized
-; RANDOM0-NEXT: @__hwasan_tls
+; ALL: @sanitized
+; ALL-NEXT: @__hwasan_tls
-; RANDOM1: @sanitized
-; RANDOM1-NEXT: %x = alloca i8, i64 4
+; NONE: @sanitized
+; NONE-NEXT: %x = alloca i8, i64 4
declare void @use(ptr)
diff --git a/llvm/test/Transforms/lower-builtin-allow-check.ll b/llvm/test/Transforms/lower-builtin-allow-check.ll
index a9f4e200c42c5f..05d940a46716c3 100644
--- a/llvm/test/Transforms/lower-builtin-allow-check.ll
+++ b/llvm/test/Transforms/lower-builtin-allow-check.ll
@@ -1,6 +1,6 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
; RUN: opt < %s -passes='function(lower-allow-check)' -S | FileCheck %s --check-prefixes=NOPROFILE
-; RUN: opt < %s -passes='function(lower-allow-check)' -lower-allow-check-random-rate=1 -S | FileCheck %s --check-prefixes=ALL
+; RUN: opt < %s -passes='function(lower-allow-check)' -lower-allow-check-random-rate=0 -S | FileCheck %s --check-prefixes=NONE
; RUN: opt < %s -passes='require<profile-summary>,function(lower-allow-check)' -lower-allow-check-percentile-cutoff-hot=990000 -S | FileCheck %s --check-prefixes=HOT99
; RUN: opt < %s -passes='require<profile-summary>,function(lower-allow-check)' -lower-allow-check-percentile-cutoff-hot=700000 -S | FileCheck %s --check-prefixes=HOT70
@@ -23,18 +23,18 @@ define dso_local noundef i32 @simple(ptr noundef readonly %0) {
; NOPROFILE-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
; NOPROFILE-NEXT: ret i32 [[TMP5]]
;
-; ALL-LABEL: define dso_local noundef i32 @simple(
-; ALL-SAME: ptr noundef readonly [[TMP0:%.*]]) {
-; ALL-NEXT: [[TMP2:%.*]] = icmp eq ptr [[TMP0]], null
-; ALL-NEXT: [[HOT:%.*]] = xor i1 false, true
-; ALL-NEXT: [[TMP6:%.*]] = or i1 [[TMP2]], [[HOT]]
-; ALL-NEXT: br i1 [[TMP6]], label [[TMP3:%.*]], label [[TMP4:%.*]]
-; ALL: 3:
-; ALL-NEXT: tail call void @llvm.ubsantrap(i8 22)
-; ALL-NEXT: unreachable
-; ALL: 4:
-; ALL-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
-; ALL-NEXT: ret i32 [[TMP5]]
+; NONE-LABEL: define dso_local noundef i32 @simple(
+; NONE-SAME: ptr noundef readonly [[TMP0:%.*]]) {
+; NONE-NEXT: [[TMP2:%.*]] = icmp eq ptr [[TMP0]], null
+; NONE-NEXT: [[HOT:%.*]] = xor i1 false, true
+; NONE-NEXT: [[TMP6:%.*]] = or i1 [[TMP2]], [[HOT]]
+; NONE-NEXT: br i1 [[TMP6]], label [[TMP3:%.*]], label [[TMP4:%.*]]
+; NONE: 3:
+; NONE-NEXT: tail call void @llvm.ubsantrap(i8 22)
+; NONE-NEXT: unreachable
+; NONE: 4:
+; NONE-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
+; NONE-NEXT: ret i32 [[TMP5]]
;
; HOT99-LABEL: define dso_local noundef i32 @simple(
; HOT99-SAME: ptr noundef readonly [[TMP0:%.*]]) {
@@ -92,18 +92,18 @@ define dso_local noundef i32 @hot(ptr noundef readonly %0) !prof !36 {
; NOPROFILE-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
; NOPROFILE-NEXT: ret i32 [[TMP5]]
;
-; ALL-LABEL: define dso_local noundef i32 @hot(
-; ALL-SAME: ptr noundef readonly [[TMP0:%.*]]) !prof [[PROF16:![0-9]+]] {
-; ALL-NEXT: [[TMP2:%.*]] = icmp eq ptr [[TMP0]], null
-; ALL-NEXT: [[HOT:%.*]] = xor i1 false, true
-; ALL-NEXT: [[TMP6:%.*]] = or i1 [[TMP2]], [[HOT]]
-; ALL-NEXT: br i1 [[TMP6]], label [[TMP3:%.*]], label [[TMP4:%.*]]
-; ALL: 3:
-; ALL-NEXT: tail call void @llvm.ubsantrap(i8 22)
-; ALL-NEXT: unreachable
-; ALL: 4:
-; ALL-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
-; ALL-NEXT: ret i32 [[TMP5]]
+; NONE-LABEL: define dso_local noundef i32 @hot(
+; NONE-SAME: ptr noundef readonly [[TMP0:%.*]]) !prof [[PROF16:![0-9]+]] {
+; NONE-NEXT: [[TMP2:%.*]] = icmp eq ptr [[TMP0]], null
+; NONE-NEXT: [[HOT:%.*]] = xor i1 false, true
+; NONE-NEXT: [[TMP6:%.*]] = or i1 [[TMP2]], [[HOT]]
+; NONE-NEXT: br i1 [[TMP6]], label [[TMP3:%.*]], label [[TMP4:%.*]]
+; NONE: 3:
+; NONE-NEXT: tail call void @llvm.ubsantrap(i8 22)
+; NONE-NEXT: unreachable
+; NONE: 4:
+; NONE-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
+; NONE-NEXT: ret i32 [[TMP5]]
;
; HOT99-LABEL: define dso_local noundef i32 @hot(
; HOT99-SAME: ptr noundef readonly [[TMP0:%.*]]) !prof [[PROF16:![0-9]+]] {
@@ -160,18 +160,18 @@ define dso_local noundef i32 @veryHot(ptr noundef readonly %0) !prof !39 {
; NOPROFILE-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
; NOPROFILE-NEXT: ret i32 [[TMP5]]
;
-; ALL-LABEL: define dso_local noundef i32 @veryHot(
-; ALL-SAME: ptr noundef readonly [[TMP0:%.*]]) !prof [[PROF17:![0-9]+]] {
-; ALL-NEXT: [[TMP2:%.*]] = icmp eq ptr [[TMP0]], null
-; ALL-NEXT: [[HOT:%.*]] = xor i1 false, true
-; ALL-NEXT: [[TMP6:%.*]] = or i1 [[TMP2]], [[HOT]]
-; ALL-NEXT: br i1 [[TMP6]], label [[TMP3:%.*]], label [[TMP4:%.*]]
-; ALL: 3:
-; ALL-NEXT: tail call void @llvm.ubsantrap(i8 22)
-; ALL-NEXT: unreachable
-; ALL: 4:
-; ALL-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
-; ALL-NEXT: ret i32 [[TMP5]]
+; NONE-LABEL: define dso_local noundef i32 @veryHot(
+; NONE-SAME: ptr noundef readonly [[TMP0:%.*]]) !prof [[PROF17:![0-9]+]] {
+; NONE-NEXT: [[TMP2:%.*]] = icmp eq ptr [[TMP0]], null
+; NONE-NEXT: [[HOT:%.*]] = xor i1 false, true
+; NONE-NEXT: [[TMP6:%.*]] = or i1 [[TMP2]], [[HOT]]
+; NONE-NEXT: br i1 [[TMP6]], label [[TMP3:%.*]], label [[TMP4:%.*]]
+; NONE: 3:
+; NONE-NEXT: tail call void @llvm.ubsantrap(i8 22)
+; NONE-NEXT: unreachable
+; NONE: 4:
+; NONE-NEXT: [[TMP5:%.*]] = load i32, ptr [[TMP0]], align 4
+; NONE-NEXT: ret i32 [[TMP5]]
;
; HOT99-LABEL: define dso_local noundef i32 @veryHot(
; HOT99-SAME: ptr noundef readonly [[TMP0:%.*]]) !prof [[PROF17:![0-9]+]] {
@@ -235,24 +235,24 @@ define dso_local noundef i32 @branchColdFnHot(i32 noundef %0, ptr noundef readon
; NOPROFILE-NEXT: [[TMP10:%.*]] = phi i32 [ [[TMP8]], [[TMP7]] ], [ 0, [[TMP2:%.*]] ]
; NOPROFILE-NEXT: ret i32 [[TMP10]]
;
-; ALL-LABEL: define dso_local noundef i32 @branchColdFnHot(
-; ALL-SAME: i32 noundef [[TMP0:%.*]], ptr noundef readonly [[TMP1:%.*]]) !prof [[PROF17]] {
-; ALL-NEXT: [[TMP3:%.*]] = icmp eq i32 [[TMP0]], 0
-; ALL-NEXT: br i1 [[TMP3]], label [[TMP9:%.*]], label [[TMP4:%.*]], !prof [[PROF18:![0-9]+]]
-; ALL: 4:
-; ALL-NEXT: [[TMP5:%.*]] = icmp eq ptr [[TMP1]], null
-; ALL-NEXT: [[HOT:%.*]] = xor i1 false, true
-; ALL-NEXT: [[TMP11:%.*]] = or i1 [[TMP5]], [[HOT]]
-; ALL-NEXT: br i1 [[TMP11]], label [[TMP6:%.*]], label [[TMP7:%.*]]
-; ALL: 6:
-; ALL-NEXT: tail call void @llvm.ubsantrap(i8 22)
-; ALL-NEXT: unreachable
-; ALL: 7:
-; ALL-NEXT: [[TMP8:%.*]] = load i32, ptr [[TMP1]], align 4
-; ALL-NEXT: br label [[TMP9]]
-; ALL: 9:
-; ALL-NEXT: [[TMP10:%.*]] = phi i32 [ [[TMP8]], [[TMP7]] ], [ 0, [[TMP2:%.*]] ]
-; ALL-NEXT: ret i32 [[TMP10]]
+; NONE-LABEL: define dso_local noundef i32 @branchColdFnHot(
+; NONE-SAME: i32 noundef [[TMP0:%.*]], ptr noundef readonly [[TMP1:%.*]]) !prof [[PROF17]] {
+; NONE-NEXT: [[TMP3:%.*]] = icmp eq i32 [[TMP0]], 0
+; NONE-NEXT: br i1 [[TMP3]], label [[TMP9:%.*]], label [[TMP4:%.*]], !prof [[PROF18:![0-9]+]]
+; NONE: 4:
+; NONE-NEXT: [[TMP5:%.*]] = icmp eq ptr [[TMP1]], null
+; NONE-NEXT: [[HOT:%.*]] = xor i1 false, true
+; NONE-NEXT: [[TMP11:%.*]] = or i1 [[TMP5]], [[HOT]]
+; NONE-NEXT: br i1 [[TMP11]], label [[TMP6:%.*]], label [[TMP7:%.*]]
+; NONE: 6:
+; NONE-NEXT: tail call void @llvm.ubsantrap(i8 22)
+; NONE-NEXT: unreachable
+; NONE: 7:
+; NONE-NEXT: [[TMP8:%.*]] = load i32, ptr [[TMP1]], align 4
+; NONE-NEXT: br label [[TMP9]]
+; NONE: 9:
+; NONE-NEXT: [[TMP10:%.*]] = phi i32 [ [[TMP8]], [[TMP7]] ], [ 0, [[TMP2:%.*]] ]
+; NONE-NEXT: ret i32 [[TMP10]]
;
; HOT99-LABEL: define dso_local noundef i32 @branchColdFnHot(
; HOT99-SAME: i32 noundef [[TMP0:%.*]], ptr noundef readonly [[TMP1:%.*]]) !prof [[PROF17]] {
@@ -335,24 +335,24 @@ define dso_local noundef i32 @branchHotFnCold(i32 noundef %0, ptr noundef readon
; NOPROFILE-NEXT: [[TMP10:%.*]] = phi i32 [ [[TMP8]], [[TMP7]] ], [ 0, [[TMP2:%.*]] ]
; NOPROFILE-NEXT: ret i32 [[TMP10]]
;
-; ALL-LABEL: define dso_local noundef i32 @branchHotFnCold(
-; ALL-SAME: i32 noundef [[TMP0:%.*]], ptr noundef readonly [[TMP1:%.*]]) !prof [[PROF16]] {
-; ALL-NEXT: [[TMP3:%.*]] = icmp eq i32 [[TMP0]], 0
-; ALL-NEXT: br i1 [[TMP3]], label [[TMP9:%.*]], label [[TMP4:%.*]], !prof [[PROF19:![0-9]+]]
-; ALL: 4:
-; ALL-NEXT: [[TMP5:%.*]] = icmp eq ptr [[TMP1]], null
-; ALL-NEXT: [[HOT:%.*]] = xor i1 false, true
-; ALL-NEXT: [[TMP11:%.*]] = or i1 [[TMP5]], [[HOT]]
-; ALL-NEXT: br i1 [[TMP11]], label [[TMP6:%.*]], label [[TMP7:%.*]]
-; ALL: 6:
-; ALL-NEXT: tail call void @llvm.ubsantrap(i8 22)
-; ALL-NEXT: unreachable
-; ALL: 7:
-; ALL-NEXT: [[TMP8:%.*]] = load i32, ptr [[TMP1]], align 4
-; ALL-NEXT: br label [[TMP9]]
-; ALL: 9:
-; ALL-NEXT: [[TMP10:%.*]] = phi i32 [ [[TMP8]], [[TMP7]] ], [ 0, [[TMP2:%.*]] ]
-; ALL-NEXT: ret i32 [[TMP10]]
+; NONE-LABEL: define dso_local noundef i32 @branchHotFnCold(
+; NONE-SAME: i32 noundef [[TMP0:%.*]], ptr noundef readonly [[TMP1:%.*]]) !prof [[PROF16]] {
+; NONE-NEXT: [[TMP3:%.*]] = icmp eq i32 [[TMP0]], 0
+; NONE-NEXT: br i1 [[TMP3]], label [[TMP9:%.*]], label [[TMP4:%.*]], !prof [[PROF19:![0-9]+]]
+; NONE: 4:
+; NONE-NEXT: [[TMP5:%.*]] = icmp eq ptr [[TMP1]], null
+; NONE-NEXT: [[HOT:%.*]] = xor i1 false, true
+; NONE-NEXT: [[TMP11:%.*]] = or i1 [[TMP5]], [[HOT]]
+; NONE-NEXT: br i1 [[TMP11]], label [[TMP6:%.*]], label [[TMP7:%.*]]
+; NONE: 6:
+; NONE-NEXT: tail call void @llvm.ubsantrap(i8 22)
+; NONE-NEXT: unreachable
+; NONE: 7:
+; NONE-NEXT: [[TMP8:%.*]] = load i32, ptr [[TMP1]], align 4
+; NONE-NEXT: br label [[TMP9]]
+; NONE: 9:
+; NONE-NEXT: [[TMP10:%.*]] = phi i32 [ [[TMP8]], [[TMP7]] ], [ 0, [[TMP2:%.*]] ]
+; NONE-NEXT: ret i32 [[TMP10]]
;
; HOT99-LABEL: define dso_local noundef i32 @branchHotFnCold(
; HOT99-SAME: i32 noundef [[TMP0:%.*]], ptr noundef readonly [[TMP1:%.*]]) !prof [[PROF16]] {
@@ -445,10 +445,10 @@ define dso_local noundef i32 @branchHotFnCold(i32 noundef %0, ptr noundef readon
; NOPROFILE: [[PROF18]] = !{!"branch_weights", i32 1000, i32 1}
; NOPROFILE: [[PROF19]] = !{!"branch_weights", i32 1, i32 1000}
;.
-; ALL: [[PROF16]] = !{!"function_entry_count", i64 1000}
-; ALL: [[PROF17]] = !{!"function_entry_count", i64 7000}
-; ALL: [[PROF18]] = !{!"branch_weights", i32 1000, i32 1}
-; ALL: [[PROF19]] = !{!"branch_weights", i32 1, i32 1000}
+; NONE: [[PROF16]] = !{!"function_entry_count", i64 1000}
+; NONE: [[PROF17]] = !{!"function_entry_count", i64 7000}
+; NONE: [[PROF18]] = !{!"branch_weights", i32 1000, i32 1}
+; NONE: [[PROF19]] = !{!"branch_weights", i32 1, i32 1000}
;.
; HOT99: [[PROF16]] = !{!"function_entry_count", i64 1000}
; HOT99: [[PROF17]] = !{!"function_entry_count", i64 7000}
|
thurstond
approved these changes
Apr 9, 2024
vitalybuka
deleted the
users/vitalybuka/spr/hwasanubsan-reverse-random-logic
branch
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Feb 13, 2025
The meaning of ClRandomSkipRate was inverted in llvm#88070 but the variable name was not changed. This patch fixes it to avoid confusion. Additionally, it elaborates the flag description to mention the interaction between the random keep rate and hotness cutoff.
thurstond
added a commit
that referenced
this pull request
Feb 13, 2025
The meaning of ClRandomSkipRate was inverted in #88070 but the variable name was not changed. This patch fixes it to avoid confusion. Additionally, it elaborates the flag description to mention the interaction between the random keep rate and hotness cutoff.
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 13, 2025
… (#126990) The meaning of ClRandomSkipRate was inverted in llvm/llvm-project#88070 but the variable name was not changed. This patch fixes it to avoid confusion. Additionally, it elaborates the flag description to mention the interaction between the random keep rate and hotness cutoff.
flovent
pushed a commit
to flovent/llvm-project
that referenced
this pull request
Feb 13, 2025
The meaning of ClRandomSkipRate was inverted in llvm#88070 but the variable name was not changed. This patch fixes it to avoid confusion. Additionally, it elaborates the flag description to mention the interaction between the random keep rate and hotness cutoff.
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
The meaning of ClRandomSkipRate was inverted in llvm#88070 but the variable name was not changed. This patch fixes it to avoid confusion. Additionally, it elaborates the flag description to mention the interaction between the random keep rate and hotness cutoff.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
The meaning of ClRandomSkipRate was inverted in llvm#88070 but the variable name was not changed. This patch fixes it to avoid confusion. Additionally, it elaborates the flag description to mention the interaction between the random keep rate and hotness cutoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels more intuitive to make higher P to keep more checks.