Skip to content

[lib++][CI] Changes bootstrap build type. #88175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mordante
Copy link
Member

@mordante mordante commented Apr 9, 2024

The RelWithDebInfo generates a few GB of debug info that is not used. Instead use the normal Release build for testing.

The RelWithDebInfo generates a few GB of debug info that is not used.
Instead use the normal Release build for testing.
@mordante mordante requested a review from a team as a code owner April 9, 2024 18:37
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Apr 9, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 9, 2024

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

The RelWithDebInfo generates a few GB of debug info that is not used. Instead use the normal Release build for testing.


Full diff: https://github.com/llvm/llvm-project/pull/88175.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/run-buildbot (+1-1)
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index 2905745355b68e..a6f3eb174308b4 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -374,7 +374,7 @@ bootstrapping-build)
           -B "${BUILD_DIR}" \
           -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
           -DCMAKE_CXX_COMPILER_LAUNCHER="ccache" \
-          -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+          -DCMAKE_BUILD_TYPE=Release \
           -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
           -DLLVM_ENABLE_PROJECTS="clang" \
           -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How did you notice this? Were we uploading artifacts for several GBs?

@mordante
Copy link
Member Author

LGTM. How did you notice this? Were we uploading artifacts for several GBs?

I ran out of disc space while testing with the LLDB in the bootstrap build. (The systems was a bit tight on space for unrelated reasons.) Then I noticed the bootrap build was a lot bigger than my development build of LLDB.

@mordante mordante merged commit 749620e into llvm:main Apr 10, 2024
@mordante mordante deleted the review/changes_bootstrap_build_type branch April 10, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants