[DWARF] Add accessor for NameIndex Offsets field. #88783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an accessor function to DWARFDebugNames::NameIndex to allow other classes to access the Offsets field within NameIndex.
|
@llvm/pr-subscribers-debuginfo Author: None (cmtice) ChangesAdd an accessor function to DWARFDebugNames::NameIndex to allow other classes to access the Offsets field within NameIndex. Full diff: https://github.com/llvm/llvm-project/pull/88783.diff 1 Files Affected:
diff --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
index 9543b78ea61309..0d447a78cdc614 100644
--- a/llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
+++ b/llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
@@ -608,6 +608,9 @@ class DWARFDebugNames : public DWARFAcceleratorTable {
/// Returns Hdr field
Header getHeader() const { return Hdr; }
+ /// Returns Offsets field
+ DWARFDebugNamesOffsets getOffsets() const { return Offsets; }
+
/// Reads offset of compilation unit CU. CU is 0-based.
uint64_t getCUOffset(uint32_t CU) const;
uint32_t getCUCount() const { return Hdr.CompUnitCount; }
|
dwblaikie
approved these changes
Apr 15, 2024
|
LGTM. Perhaps the commit message (first comment) can be clarified to say that this will be used by BTW, most commit messages omit a full stop for the subject line. |
MaskRay
approved these changes
Apr 15, 2024
aniplcc
pushed a commit
to aniplcc/llvm-project
that referenced
this pull request
Apr 15, 2024
Add an accessor function to DWARFDebugNames::NameIndex to allow other classes to access the Offsets field within NameIndex. This will be used by LLD to create a merged .debug_names index (llvm#86508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an accessor function to DWARFDebugNames::NameIndex to allow other classes to access the Offsets field within NameIndex. This will be used by LLD to create a merged .debug_names index (#86508)