[flang] Remove obsolete flang-to-external-fc tool #88904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banach-space
approved these changes
Apr 16, 2024
|
I have not seen any feedback for my post at https://discourse.llvm.org/t/flang-is-flang-to-external-fc-still-needed/78289. I guess, we can remove the tool and see if we get complaints? |
SGTM 👍🏻 |
tblah
approved these changes
Apr 18, 2024
|
Plus, the removal of the f18.mod files has been merged a good while ago and nobody seems to have noticed. So, I'll go ahead and merge tomorrow to provide another window for objections. |
aniplcc
pushed a commit
to aniplcc/llvm-project
that referenced
this pull request
Apr 21, 2024
It seems like the `flang-to-external-fc` tool is no longer needed, because Flang is now a full compiler in its own right. After PR llvm#85249 has landed, this tool will not be able to pick up the `.f18.mod` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the
flang-to-external-fctool is no longer needed, because Flang is now a full compiler in its own right. After PR #85249 has landed, this tool will not be able to pick up the.f18.modfiles.