Skip to content

[github] Add myself as default code reviewer #89099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[github] Add myself as default code reviewer #89099

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
072ed83
add owner
grypp Apr 17, 2024
81f10b2
delete the previous line
grypp Apr 18, 2024
07842db
Merge branch 'main' into owners
grypp Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ clang/test/AST/Interp/ @tbaederr

# MLIR NVVM Dialect in MLIR
/mlir/**/LLVMIR/**/BasicPtxBuilderInterface* @grypp
/mlir/**/NVVM*/ @grypp
/mlir/**/NVVM* @grypp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this making the one on the line before obsolete?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first one catches /mlir/**/Target/LLVM/NVVM/Target.* files, but I haven't implemented them, so I have removed that line


# MLIR Python Bindings
/mlir/test/python/ @makslevental @stellaraccident
Expand Down