Skip to content

[flang] Rename AddDebugFoundation to AddDebugInfo (NFC) #89191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[flang] Rename AddDebugFoundation to AddDebugInfo (NFC) #89191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e265feb
[flang] Rename AddDebugFoundation to AddDebugInfo (NFC)
abidh Apr 15, 2024
b5cb5bc
Fix formatting issue.
abidh Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flang/include/flang/Optimizer/Transforms/Passes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def MemRefDataFlowOpt : Pass<"fir-memref-dataflow-opt", "::mlir::func::FuncOp">
def AddDebugInfo : Pass<"add-debug-info", "mlir::ModuleOp"> {
let summary = "Add the debug info";
let description = [{
Add the foundation for emitting debug info that can be understood by llvm.
Emit debug info that can be understood by llvm.
}];
let constructor = "::fir::createAddDebugInfoPass()";
let dependentDialects = [
Expand Down
6 changes: 3 additions & 3 deletions flang/include/flang/Tools/CLOptions.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static llvm::cl::opt<bool> useOldAliasTags("use-old-alias-tags",
#if !defined(FLANG_EXCLUDE_CODEGEN)
DisableOption(CodeGenRewrite, "codegen-rewrite", "rewrite FIR for codegen");
DisableOption(TargetRewrite, "target-rewrite", "rewrite FIR for target");
DisableOption(DebugFoundation, "debug-foundation", "Add debug foundation");
DisableOption(DebugInfo, "debug-info", "Add debug info");
DisableOption(FirToLlvmIr, "fir-to-llvmir", "FIR to LLVM-IR dialect");
DisableOption(LlvmIrToLlvm, "llvm", "conversion to LLVM");
DisableOption(BoxedProcedureRewrite, "boxed-procedure-rewrite",
Expand Down Expand Up @@ -156,8 +156,8 @@ inline void addTargetRewritePass(mlir::PassManager &pm) {
}

inline void addDebugInfoPass(mlir::PassManager &pm) {
addPassConditionally(pm, disableDebugFoundation,
[&]() { return fir::createAddDebugInfoPass(); });
addPassConditionally(
pm, disableDebugInfo, [&]() { return fir::createAddDebugInfoPass(); });
}

inline void addFIRToLLVMPass(
Expand Down
2 changes: 1 addition & 1 deletion flang/lib/Optimizer/Transforms/AddDebugInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace fir {
#include "flang/Optimizer/Transforms/Passes.h.inc"
} // namespace fir

#define DEBUG_TYPE "flang-add-debug-foundation"
#define DEBUG_TYPE "flang-add-debug-info"

namespace {

Expand Down