[NVPTX][NFCI] Use DataLayout to determine short shared/local/const pointers #89404
+54
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artem-B
approved these changes
Apr 19, 2024
Comment on lines
+770
to
+773
| Opc = TM.is64Bit() ? (TM.getPointerSizeInBits(SrcAddrSpace) == 32 | ||
| ? NVPTX::cvta_shared_6432 | ||
| : NVPTX::cvta_shared_64) | ||
| : NVPTX::cvta_shared; |
There was a problem hiding this comment.
This looks like a common pattern. We could extract it into a helper function
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the datalayout directly to determine the correct
cvtainstruction for converting shared/local/const pointers. This is cleaner as it eliminates the need to keep a redundant copy of this info in the TM and makes clear which address spaces short pointers are applicable for.