[tidy] add new check bugprone-return-const-ref-from-parameter #89497

HerrCai0907 · 2024-04-20T09:59:59Z

Detects the function which returns the const reference from parameter which causes potential use after free if the caller uses xvalue as argument.
In c++, const reference parameter can accept xvalue which will be destructed after the call. When the function returns this parameter also as const reference, then the returned reference can be used after the object it refers to has been destroyed.
Fixes: #85253

Detects the function which returns the const reference from parameter which causes potential use after free if the caller uses xvalue as argument. In c++, const reference parameter can accept xvalue which will be destructed after the call. When the function returns this parameter also as const reference, then the returned reference can be used after the object it refers to has been destroyed. Fixes: llvm#85253

llvmbot · 2024-04-20T10:00:34Z

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-tidy

Author: Congcong Cai (HerrCai0907)

Changes

Detects the function which returns the const reference from parameter which
causes potential use after free if the caller uses xvalue as argument.
In c++, const reference parameter can accept xvalue which will be destructed
after the call. When the function returns this parameter also as const reference,
then the returned reference can be used after the object it refers to has been
destroyed.
Fixes: #85253

Full diff: https://github.com/llvm/llvm-project/pull/89497.diff

8 Files Affected:

(modified) clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp (+3)
(modified) clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt (+1)
(added) clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp (+41)
(added) clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.h (+35)
(modified) clang-tools-extra/docs/ReleaseNotes.rst (+6)
(added) clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst (+30)
(modified) clang-tools-extra/docs/clang-tidy/checks/list.rst (+5-4)
(added) clang-tools-extra/test/clang-tidy/checkers/bugprone/return-const-ref-from-parameter.cpp (+31)

diff --git a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
index 2931325d8b5798..1b92d2e60cc173 100644
--- a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
@@ -54,6 +54,7 @@
 #include "PosixReturnCheck.h"
 #include "RedundantBranchConditionCheck.h"
 #include "ReservedIdentifierCheck.h"
+#include "ReturnConstRefFromParameterCheck.h"
 #include "SharedPtrArrayMismatchCheck.h"
 #include "SignalHandlerCheck.h"
 #include "SignedCharMisuseCheck.h"
@@ -137,6 +138,8 @@ class BugproneModule : public ClangTidyModule {
         "bugprone-inaccurate-erase");
     CheckFactories.registerCheck<IncorrectEnableIfCheck>(
         "bugprone-incorrect-enable-if");
+    CheckFactories.registerCheck<ReturnConstRefFromParameterCheck>(
+        "bugprone-return-const-ref-from-parameter");
     CheckFactories.registerCheck<SwitchMissingDefaultCaseCheck>(
         "bugprone-switch-missing-default-case");
     CheckFactories.registerCheck<IncDecInConditionsCheck>(
diff --git a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
index 081ba67efe1538..2d303191f88650 100644
--- a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
@@ -26,6 +26,7 @@ add_clang_library(clangTidyBugproneModule
   ImplicitWideningOfMultiplicationResultCheck.cpp
   InaccurateEraseCheck.cpp
   IncorrectEnableIfCheck.cpp
+  ReturnConstRefFromParameterCheck.cpp
   SuspiciousStringviewDataUsageCheck.cpp
   SwitchMissingDefaultCaseCheck.cpp
   IncDecInConditionsCheck.cpp
diff --git a/clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp
new file mode 100644
index 00000000000000..87fc663231496e
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp
@@ -0,0 +1,41 @@
+//===--- ReturnConstRefFromParameterCheck.cpp - clang-tidy ----------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "ReturnConstRefFromParameterCheck.h"
+#include "../utils/Matchers.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::bugprone {
+
+std::optional<TraversalKind>
+ReturnConstRefFromParameterCheck::getCheckTraversalKind() const {
+  // Use 'AsIs' to make sure the return type is exactly the same as the
+  // parameter type.
+  return TK_AsIs;
+}
+
+void ReturnConstRefFromParameterCheck::registerMatchers(MatchFinder *Finder) {
+  Finder->addMatcher(
+      returnStmt(hasReturnValue(declRefExpr(to(parmVarDecl(hasType(
+                     hasCanonicalType(matchers::isReferenceToConst())))))))
+          .bind("ret"),
+      this);
+}
+
+void ReturnConstRefFromParameterCheck::check(
+    const MatchFinder::MatchResult &Result) {
+  const auto *R = Result.Nodes.getNodeAs<ReturnStmt>("ret");
+  diag(R->getRetValue()->getBeginLoc(),
+       "return const reference parameter cause potential use-after-free "
+       "when function accepts immediately constructed value.");
+}
+
+} // namespace clang::tidy::bugprone
diff --git a/clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.h b/clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.h
new file mode 100644
index 00000000000000..96d02aa2563edf
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.h
@@ -0,0 +1,35 @@
+//===--- ReturnConstRefFromParameterCheck.h - clang-tidy --------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_RETURNCONSTREFFROMPARAMETERCHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_RETURNCONSTREFFROMPARAMETERCHECK_H
+
+#include "../ClangTidyCheck.h"
+
+namespace clang::tidy::bugprone {
+
+/// Detects the function which returns the const reference from parameter which
+/// causes potential use after free if the caller uses xvalue as argument.
+///
+/// For the user-facing documentation see:
+/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone/return-const-ref-from-parameter.html
+class ReturnConstRefFromParameterCheck : public ClangTidyCheck {
+public:
+  ReturnConstRefFromParameterCheck(StringRef Name, ClangTidyContext *Context)
+      : ClangTidyCheck(Name, Context) {}
+  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+  std::optional<TraversalKind> getCheckTraversalKind() const override;
+  bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
+    return LangOpts.CPlusPlus;
+  }
+};
+
+} // namespace clang::tidy::bugprone
+
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_RETURNCONSTREFFROMPARAMETERCHECK_H
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index a457e6fcae9462..3e5ad76bde3243 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -112,6 +112,12 @@ New checks
   Detects error-prone Curiously Recurring Template Pattern usage, when the CRTP
   can be constructed outside itself and the derived class.
 
+- New :doc:`bugprone-return-const-ref-from-parameter
+  <clang-tidy/checks/bugprone/return-const-ref-from-parameter>` check.
+
+  Detects the function which returns the const reference from parameter which
+  causes potential use after free if the caller uses xvalue as argument.
+
 - New :doc:`bugprone-suspicious-stringview-data-usage
   <clang-tidy/checks/bugprone/suspicious-stringview-data-usage>` check.
 
diff --git a/clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst b/clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst
new file mode 100644
index 00000000000000..ec3fd439feb623
--- /dev/null
+++ b/clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst
@@ -0,0 +1,30 @@
+.. title:: clang-tidy - bugprone-return-const-ref-from-parameter
+
+bugprone-return-const-ref-from-parameter
+========================================
+
+Detects the function which returns the const reference from parameter which
+causes potential use after free if the caller uses xvalue as argument.
+
+In c++, const reference parameter can accept xvalue which will be destructed
+after the call. When the function returns this parameter also as const reference,
+then the returned reference can be used after the object it refers to has been
+destroyed.
+
+Example
+-------
+
+.. code-block:: c++
+
+  struct S {
+    int v;
+    S(int);
+    ~S();
+  };
+  
+  const S &fn(const S &a) {
+    return a;
+  }
+
+  const S& s = fn(S{1});
+  s.v; // use after free
diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst
index 8bc46acad56c84..5d9d487f75f9cb 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -120,6 +120,7 @@ Clang-Tidy Checks
    :doc:`bugprone-posix-return <bugprone/posix-return>`, "Yes"
    :doc:`bugprone-redundant-branch-condition <bugprone/redundant-branch-condition>`, "Yes"
    :doc:`bugprone-reserved-identifier <bugprone/reserved-identifier>`, "Yes"
+   :doc:`bugprone-return-const-ref-from-parameter <bugprone/return-const-ref-from-parameter>`
    :doc:`bugprone-shared-ptr-array-mismatch <bugprone/shared-ptr-array-mismatch>`, "Yes"
    :doc:`bugprone-signal-handler <bugprone/signal-handler>`,
    :doc:`bugprone-signed-char-misuse <bugprone/signed-char-misuse>`,
@@ -341,9 +342,9 @@ Clang-Tidy Checks
    :doc:`portability-std-allocator-const <portability/std-allocator-const>`,
    :doc:`readability-avoid-const-params-in-decls <readability/avoid-const-params-in-decls>`, "Yes"
    :doc:`readability-avoid-nested-conditional-operator <readability/avoid-nested-conditional-operator>`,
-   :doc:`readability-avoid-return-with-void-value <readability/avoid-return-with-void-value>`,
+   :doc:`readability-avoid-return-with-void-value <readability/avoid-return-with-void-value>`, "Yes"
    :doc:`readability-avoid-unconditional-preprocessor-if <readability/avoid-unconditional-preprocessor-if>`,
-   :doc:`readability-braces-around-statements <readability/braces-around-statements>`, "Yes"
+   :doc:`readability-braces-around-statements <readability/braces-around-statements>`,
    :doc:`readability-const-return-type <readability/const-return-type>`, "Yes"
    :doc:`readability-container-contains <readability/container-contains>`, "Yes"
    :doc:`readability-container-data-pointer <readability/container-data-pointer>`, "Yes"
@@ -529,12 +530,12 @@ Clang-Tidy Checks
    :doc:`cppcoreguidelines-non-private-member-variables-in-classes <cppcoreguidelines/non-private-member-variables-in-classes>`, :doc:`misc-non-private-member-variables-in-classes <misc/non-private-member-variables-in-classes>`,
    :doc:`cppcoreguidelines-use-default-member-init <cppcoreguidelines/use-default-member-init>`, :doc:`modernize-use-default-member-init <modernize/use-default-member-init>`, "Yes"
    :doc:`fuchsia-header-anon-namespaces <fuchsia/header-anon-namespaces>`, :doc:`google-build-namespaces <google/build-namespaces>`,
-   :doc:`google-readability-braces-around-statements <google/readability-braces-around-statements>`, :doc:`readability-braces-around-statements <readability/braces-around-statements>`, "Yes"
+   :doc:`google-readability-braces-around-statements <google/readability-braces-around-statements>`, :doc:`readability-braces-around-statements <readability/braces-around-statements>`,
    :doc:`google-readability-function-size <google/readability-function-size>`, :doc:`readability-function-size <readability/function-size>`,
    :doc:`google-readability-namespace-comments <google/readability-namespace-comments>`, :doc:`llvm-namespace-comment <llvm/namespace-comment>`,
    :doc:`hicpp-avoid-c-arrays <hicpp/avoid-c-arrays>`, :doc:`modernize-avoid-c-arrays <modernize/avoid-c-arrays>`,
    :doc:`hicpp-avoid-goto <hicpp/avoid-goto>`, :doc:`cppcoreguidelines-avoid-goto <cppcoreguidelines/avoid-goto>`,
-   :doc:`hicpp-braces-around-statements <hicpp/braces-around-statements>`, :doc:`readability-braces-around-statements <readability/braces-around-statements>`, "Yes"
+   :doc:`hicpp-braces-around-statements <hicpp/braces-around-statements>`, :doc:`readability-braces-around-statements <readability/braces-around-statements>`,
    :doc:`hicpp-deprecated-headers <hicpp/deprecated-headers>`, :doc:`modernize-deprecated-headers <modernize/deprecated-headers>`, "Yes"
    :doc:`hicpp-explicit-conversions <hicpp/explicit-conversions>`, :doc:`google-explicit-constructor <google/explicit-constructor>`, "Yes"
    :doc:`hicpp-function-size <hicpp/function-size>`, :doc:`readability-function-size <readability/function-size>`,
diff --git a/clang-tools-extra/test/clang-tidy/checkers/bugprone/return-const-ref-from-parameter.cpp b/clang-tools-extra/test/clang-tidy/checkers/bugprone/return-const-ref-from-parameter.cpp
new file mode 100644
index 00000000000000..35e4476298b55f
--- /dev/null
+++ b/clang-tools-extra/test/clang-tidy/checkers/bugprone/return-const-ref-from-parameter.cpp
@@ -0,0 +1,31 @@
+// RUN: %check_clang_tidy %s bugprone-return-const-ref-from-parameter %t
+
+using T = int;
+using TConst = int const;
+using TConstRef = int const&;
+
+namespace invalid {
+
+int const &f1(int const &a) { return a; }
+// CHECK-MESSAGES: :[[@LINE-1]]:38: warning: return const reference parameter
+
+int const &f2(T const &a) { return a; }
+// CHECK-MESSAGES: :[[@LINE-1]]:36: warning: return const reference parameter
+
+int const &f3(TConstRef a) { return a; }
+// CHECK-MESSAGES: :[[@LINE-1]]:37: warning: return const reference parameter
+
+int const &f4(TConst &a) { return a; }
+// CHECK-MESSAGES: :[[@LINE-1]]:35: warning: return const reference parameter
+
+} // namespace invalid
+
+namespace valid {
+
+int const &f1(int &a) { return a; }
+
+int const &f2(int &&a) { return a; }
+
+int f1(int const &a) { return a; }
+
+} // namespace valid

clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst

clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp

SimplyDanny · 2024-04-20T14:20:02Z

clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.h

+/// Detects the function which returns the const reference from parameter which
+/// causes potential use after free if the caller uses xvalue as argument.


Suggested change

/// Detects the function which returns the const reference from parameter which

/// causes potential use after free if the caller uses xvalue as argument.

/// Detects statements that return constant reference parameters as constant

/// references. This might cause potential use after free errors if the caller

/// uses xvalues as arguments.

looks better.
Could you explain more about why here should use constant reference. const reference can map to const & semantics directly.

My thought was that this is text and "const" is not an English word but "constant" and const is a keyword. On the other hand, "const reference" is a well known term to C++ people. So in the end, it should be consistent with existing text in the project. Alternatively, putting the term monospaced as const & would also work I guess.

I think Detects statements that return constant should actually be Detects return statements that return constant.

As for consistency: in docs/clang-tidy, there are ~116 const's (minus const in code snippets and check names) where ~50% of them are in ``, and there are 91 constants (although 60 are in identifier-naming.rst.

might cause potential sounds not right to me, the might and potential mean the same thing IMO.
I would suggest: This might cause use-after-free errors ... (or with may instead of might)

clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst

clang-tools-extra/docs/clang-tidy/checks/list.rst

clang-tools-extra/docs/ReleaseNotes.rst

clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp

5chmidti · 2024-04-21T16:34:13Z

clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.h

+/// Detects the function which returns the const reference from parameter which
+/// causes potential use after free if the caller uses xvalue as argument.


I think Detects statements that return constant should actually be Detects return statements that return constant.

As for consistency: in docs/clang-tidy, there are ~116 const's (minus const in code snippets and check names) where ~50% of them are in ``, and there are 91 constants (although 60 are in identifier-naming.rst.

might cause potential sounds not right to me, the might and potential mean the same thing IMO.
I would suggest: This might cause use-after-free errors ... (or with may instead of might)

clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst

clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp

…-ref-from-parameter.rst Co-authored-by: Danny Mösch <[email protected]>

SimplyDanny

Only a few more nits from my side.

clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.h

clang-tools-extra/docs/ReleaseNotes.rst

clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst

…-ref-from-parameter.rst Co-authored-by: Danny Mösch <[email protected]>

…terCheck.h Co-authored-by: Danny Mösch <[email protected]>

Co-authored-by: Danny Mösch <[email protected]>

llvmbot added clang-tools-extra clang-tidy labels Apr 20, 2024

HerrCai0907 requested review from PiotrZSL and 5chmidti April 20, 2024 10:00

HerrCai0907 requested a review from SimplyDanny April 20, 2024 10:01

EugeneZelenko reviewed Apr 20, 2024

View reviewed changes

clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst Outdated Show resolved Hide resolved

SimplyDanny reviewed Apr 20, 2024

View reviewed changes

HerrCai0907 added 2 commits April 21, 2024 11:55

fix doc

401c775

revert list

322a819

EugeneZelenko reviewed Apr 21, 2024

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

5chmidti reviewed Apr 21, 2024

View reviewed changes

fix comment

2ce9fe7

HerrCai0907 force-pushed the bugprone-return-const-ref-from-parameter branch from 99140d7 to 2ce9fe7 Compare April 22, 2024 05:58

SimplyDanny reviewed Apr 22, 2024

View reviewed changes

clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const-ref-from-parameter.rst Outdated Show resolved Hide resolved

clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp Show resolved Hide resolved

Update clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const…

c63a9fa

…-ref-from-parameter.rst Co-authored-by: Danny Mösch <[email protected]>

SimplyDanny approved these changes Apr 23, 2024

View reviewed changes

HerrCai0907 and others added 3 commits April 23, 2024 17:57

Update clang-tools-extra/docs/clang-tidy/checks/bugprone/return-const…

4a236f3

…-ref-from-parameter.rst Co-authored-by: Danny Mösch <[email protected]>

Update clang-tools-extra/clang-tidy/bugprone/ReturnConstRefFromParame…

406a3d1

…terCheck.h Co-authored-by: Danny Mösch <[email protected]>

Update clang-tools-extra/docs/ReleaseNotes.rst

5d8110b

Co-authored-by: Danny Mösch <[email protected]>

HerrCai0907 merged commit d56f08b into llvm:main Apr 23, 2024

HerrCai0907 deleted the bugprone-return-const-ref-from-parameter branch April 23, 2024 23:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[tidy] add new check bugprone-return-const-ref-from-parameter #89497

[tidy] add new check bugprone-return-const-ref-from-parameter #89497

Uh oh!

HerrCai0907 commented Apr 20, 2024 •

edited

Loading

Uh oh!

llvmbot commented Apr 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimplyDanny Apr 20, 2024

Uh oh!

HerrCai0907 Apr 21, 2024

Uh oh!

SimplyDanny Apr 21, 2024

Uh oh!

5chmidti Apr 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

5chmidti Apr 21, 2024

Uh oh!

Uh oh!

Uh oh!

SimplyDanny left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

		/// Detects the function which returns the const reference from parameter which
		/// causes potential use after free if the caller uses xvalue as argument.

-/// Detects the function which returns the const reference from parameter which
-/// causes potential use after free if the caller uses xvalue as argument.
+/// Detects statements that return constant reference parameters as constant
+/// references. This might cause potential use after free errors if the caller
+/// uses xvalues as arguments.

[tidy] add new check bugprone-return-const-ref-from-parameter #89497

[tidy] add new check bugprone-return-const-ref-from-parameter #89497

Uh oh!

Conversation

HerrCai0907 commented Apr 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Apr 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimplyDanny Apr 20, 2024

Choose a reason for hiding this comment

Uh oh!

HerrCai0907 Apr 21, 2024

Choose a reason for hiding this comment

Uh oh!

SimplyDanny Apr 21, 2024

Choose a reason for hiding this comment

Uh oh!

5chmidti Apr 21, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

5chmidti Apr 21, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SimplyDanny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HerrCai0907 commented Apr 20, 2024 •

edited

Loading

llvmbot commented Apr 20, 2024 •

edited

Loading