Skip to content

[lldb][DAP] Fix test failure from #73393 #89692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[lldb][DAP] Fix test failure from #73393 #89692

merged 1 commit into from
Apr 23, 2024

Conversation

pranavk
Copy link
Contributor

@pranavk pranavk commented Apr 23, 2024

#73393 introduced a mandatory column field. Update test for that.

@pranavk pranavk requested a review from JDevlieghere as a code owner April 23, 2024 00:27
@llvmbot llvmbot added the lldb label Apr 23, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 23, 2024

@llvm/pr-subscribers-lldb

Author: Pranav Kant (pranavk)

Changes

#73393 introduced a mandatory column field. Update test for that.


Full diff: https://github.com/llvm/llvm-project/pull/89692.diff

1 Files Affected:

  • (modified) lldb/test/API/tools/lldb-dap/coreFile/TestDAP_coreFile.py (+3)
diff --git a/lldb/test/API/tools/lldb-dap/coreFile/TestDAP_coreFile.py b/lldb/test/API/tools/lldb-dap/coreFile/TestDAP_coreFile.py
index 13190a50954ad7..cabaeafc4a6418 100644
--- a/lldb/test/API/tools/lldb-dap/coreFile/TestDAP_coreFile.py
+++ b/lldb/test/API/tools/lldb-dap/coreFile/TestDAP_coreFile.py
@@ -25,6 +25,7 @@ def test_core_file(self):
 
         expected_frames = [
             {
+                "column": 0,
                 "id": 524288,
                 "line": 4,
                 "name": "bar",
@@ -32,6 +33,7 @@ def test_core_file(self):
                 "instructionPointerReference": "0x40011C",
             },
             {
+                "column": 0,
                 "id": 524289,
                 "line": 10,
                 "name": "foo",
@@ -39,6 +41,7 @@ def test_core_file(self):
                 "instructionPointerReference": "0x400142",
             },
             {
+                "column": 0,
                 "id": 524290,
                 "line": 16,
                 "name": "_start",

@pranavk
Copy link
Contributor Author

pranavk commented Apr 23, 2024

Merging this after self-review. Need this to unblock something internally for us. Hope you don't mind.

@pranavk pranavk merged commit aa89c1b into llvm:main Apr 23, 2024
Copy link
Collaborator

@rupprecht rupprecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JDevlieghere pushed a commit to swiftlang/llvm-project that referenced this pull request May 24, 2024
llvm#73393 introduced a mandatory column field. Update test for that.

(cherry picked from commit aa89c1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants