Skip to content

[lldb][tests] Add ability to run API tests with qemu-user simulator #89765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ita-sc
Copy link
Contributor

@ita-sc ita-sc commented Apr 23, 2024

No description provided.

@ita-sc ita-sc requested a review from JDevlieghere as a code owner April 23, 2024 13:29
@llvmbot llvmbot added the lldb label Apr 23, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 23, 2024

@llvm/pr-subscribers-lldb

Author: None (ita-sc)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/89765.diff

1 Files Affected:

  • (modified) lldb/test/API/lit.cfg.py (+7)
diff --git a/lldb/test/API/lit.cfg.py b/lldb/test/API/lit.cfg.py
index 9d6775917e1370..5e5fc750f529d5 100644
--- a/lldb/test/API/lit.cfg.py
+++ b/lldb/test/API/lit.cfg.py
@@ -162,6 +162,9 @@ def delete_module_cache(path):
     elif lldb_use_simulator == "tvos":
         lit_config.note("Running API tests on tvOS simulator")
         config.available_features.add("lldb-simulator-tvos")
+    elif lldb_use_simulator == "qemu-user":
+        lit_config.note("Running API tests on qemu-user simulator")
+        config.available_features.add("lldb-simulator-qemu-user")
     else:
         lit_config.error("Unknown simulator id '{}'".format(lldb_use_simulator))
 
@@ -268,6 +271,10 @@ def delete_module_cache(path):
         "tvos-simulator",
     ]
 
+if "lldb-simulator-qemu-user" in config.available_features:
+    dotest_cmd += ["--platform-name",
+                   "qemu-user"]
+
 if is_configured("enabled_plugins"):
     for plugin in config.enabled_plugins:
         dotest_cmd += ["--enable-plugin", plugin]

Copy link

github-actions bot commented Apr 23, 2024

✅ With the latest revision this PR passed the Python code formatter.

Copy link
Member

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the formatting fixed.

@ita-sc ita-sc force-pushed the pr/qemu_user_as_simulator branch from ec086f9 to 3d95e1f Compare April 24, 2024 08:36
@ita-sc
Copy link
Contributor Author

ita-sc commented Jul 18, 2024

Sorry for huge delay, could you please merge this? (I do not have write access yet)

@DavidSpickett
Copy link
Collaborator

@ita-sc is this still any use to you? If not I will close this.

(sorry this fell through the cracks, I am currently looking for a solution to stop this happening)

@ita-sc ita-sc force-pushed the pr/qemu_user_as_simulator branch from 3d95e1f to 713fb81 Compare March 3, 2025 14:40
@ita-sc
Copy link
Contributor Author

ita-sc commented Mar 3, 2025

@DavidSpickett, yep, it is still relevant. Could you please take a look at this and merge if it is ok to you?

@DavidSpickett
Copy link
Collaborator

Yes looks fine, please setup a valid email address and then I'll get it merged.

@ita-sc ita-sc force-pushed the pr/qemu_user_as_simulator branch from 713fb81 to 94b52a2 Compare March 6, 2025 09:47
@ita-sc
Copy link
Contributor Author

ita-sc commented Mar 6, 2025

@DavidSpickett, seems done: I've disabled Keep my email addresses private.

@DavidSpickett DavidSpickett merged commit 8eec3d7 into llvm:main Mar 6, 2025
6 of 9 checks passed
@DavidSpickett
Copy link
Collaborator

Yes, that fixed it.

jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants