-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[lldb][tests] Add ability to run API tests with qemu-user simulator #89765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-lldb Author: None (ita-sc) ChangesFull diff: https://github.com/llvm/llvm-project/pull/89765.diff 1 Files Affected:
diff --git a/lldb/test/API/lit.cfg.py b/lldb/test/API/lit.cfg.py
index 9d6775917e1370..5e5fc750f529d5 100644
--- a/lldb/test/API/lit.cfg.py
+++ b/lldb/test/API/lit.cfg.py
@@ -162,6 +162,9 @@ def delete_module_cache(path):
elif lldb_use_simulator == "tvos":
lit_config.note("Running API tests on tvOS simulator")
config.available_features.add("lldb-simulator-tvos")
+ elif lldb_use_simulator == "qemu-user":
+ lit_config.note("Running API tests on qemu-user simulator")
+ config.available_features.add("lldb-simulator-qemu-user")
else:
lit_config.error("Unknown simulator id '{}'".format(lldb_use_simulator))
@@ -268,6 +271,10 @@ def delete_module_cache(path):
"tvos-simulator",
]
+if "lldb-simulator-qemu-user" in config.available_features:
+ dotest_cmd += ["--platform-name",
+ "qemu-user"]
+
if is_configured("enabled_plugins"):
for plugin in config.enabled_plugins:
dotest_cmd += ["--enable-plugin", plugin]
|
✅ With the latest revision this PR passed the Python code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the formatting fixed.
ec086f9
to
3d95e1f
Compare
Sorry for huge delay, could you please merge this? (I do not have write access yet) |
@ita-sc is this still any use to you? If not I will close this. (sorry this fell through the cracks, I am currently looking for a solution to stop this happening) |
3d95e1f
to
713fb81
Compare
@DavidSpickett, yep, it is still relevant. Could you please take a look at this and merge if it is ok to you? |
Yes looks fine, please setup a valid email address and then I'll get it merged. |
713fb81
to
94b52a2
Compare
@DavidSpickett, seems done: I've disabled |
Yes, that fixed it. |
No description provided.