-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[mlir][linalg] Block pack matmul pass #89782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
ad5de2b
[mlir][linalg] Pack matmul pass
adam-smnk b2f7ab4
Improve test naming
adam-smnk e2ad091
Improve description
adam-smnk 5e6aff8
Pack options
adam-smnk 80b1aae
Comments
adam-smnk 13bc86a
Expand autos
adam-smnk f49aaf0
Docs
adam-smnk ef541d7
Rename to block pack matmul
adam-smnk ce2238d
Add test cases
adam-smnk 204f379
Formatting
adam-smnk 6003bdd
Fix transposition for matmul variants
adam-smnk cf6ca57
Cleanup test
adam-smnk 22069e2
WIP better options
adam-smnk 825228a
WIP better options 2
adam-smnk ac9b8a3
Update tests
adam-smnk 91be909
Update descriptions
adam-smnk 2c47521
Refactor
adam-smnk 9bf77ea
Refactor
adam-smnk 8c97c6a
More tests
adam-smnk 5d8dead
Allow dynamic shapes
adam-smnk 94e4fb7
Support simple generics
adam-smnk de91624
Merge branch 'main' into linalg-pack-matmul
adam-smnk 6598369
Typo
adam-smnk d4befc9
Tweak test syntax
adam-smnk 24302cc
Add $ to test variables
adam-smnk 5b4a804
Relax assumption on 4D matmul for transpostion
adam-smnk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not going to hold on to it, but I really dislike having such passes. I think this is just dead weight, and can never fit all downstream uses, and really we should need just transformation methods/patterns and let the passes live downstream and just have a test pass for testing. Such passes in core do not age well.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, but I think it's orthogonal. We need the functionality upstream so that we can all use and share, and it will only age if no one uses. Being in a test pass or a transform or a dialect pass won't change much that equation.
I'd love if IREE and other compilers could bring more functionality to this pass and start using the upstream stuff (parametrized, cost modelled, etc). This is what makes them not age. If we don't provide a way for people to use in their projects, then MLIR gets less "batteries" (as @joker-eph usually say).