[clang][NFC] Reformat suspicious condition

[Troy-Butler]

Addresses issue #89805.
Assignment + comparison performed in conditional statement. Resolved by parenthesizing comparison operation.

Fixes #89805.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Troy Butler (Troy-Butler)

Changes

Addresses issue #89805.

Assignment + comparison performed in conditional statement. Resolved by parenthesizing comparison operation.

---

Full diff: https://github.com/llvm/llvm-project/pull/89923.diff

1 Files Affected:

• (modified) clang/lib/Lex/Pragma.cpp (+1-1)

diff --git a/clang/lib/Lex/Pragma.cpp b/clang/lib/Lex/Pragma.cpp
index 499813f8ab7df0..ced407355e0015 100644
--- a/clang/lib/Lex/Pragma.cpp
+++ b/clang/lib/Lex/Pragma.cpp
@@ -1444,7 +1444,7 @@ struct PragmaWarningHandler : public PragmaHandler {
                                  .Case("once", PPCallbacks::PWS_Once)
                                  .Case("suppress", PPCallbacks::PWS_Suppress)
                                  .Default(-1);
-          if ((SpecifierValid = SpecifierInt != -1))
+          if (SpecifierValid = (SpecifierInt != -1))
             Specifier =
                 static_cast<PPCallbacks::PragmaWarningSpecifier>(SpecifierInt);
 

[cor3ntin]

Thanks for your contribution.
Will you need me to merge that for you?

[Troy-Butler]

Thanks for your contribution. Will you need me to merge that for you?

Yes, if you don't mind! I don't have merging rights. Thank you!

[shafik]

This makes sense, I added Nico since they added the change that brought in that line.

[Troy-Butler]

I see that the build has failed - what do I need to do to fix this?

[AaronBallman]

I see that the build has failed - what do I need to do to fix this?

That build failure looks unrelated to your changes, I think it just got caught in a bad state. You can try pushing no changes to the branch to kick off a new build just to be sure, though.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[shafik]

The amdgpu-toolchain.c test failure looks unrelated. I think we need another empty commit to kick off the build again unfortunately.

[cor3ntin]

I think CI is having some difficulties. No need to wait for it for this.
Thanks a lot for your first contribution!
We have some good first issues if you want to have a go at some more contributions
https://github.com/llvm/llvm-project/issues?q=is%3Aissue+is%3Aopen+good+first+issues+label%3A%22good+first+issue%22

[fhahn]

Unfortunately this introduces a new warning

/Users/florianhahn/projects/llvm-project/clang/lib/Lex/Pragma.cpp:1447:30: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
 1447 |           if (SpecifierValid = (SpecifierInt != -1))
      |               ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
/Users/florianhahn/projects/llvm-project/clang/lib/Lex/Pragma.cpp:1447:30: note: place parentheses around the assignment to silence this warning
 1447 |           if (SpecifierValid = (SpecifierInt != -1))
      |                              ^
      |               (                                    )
/Users/florianhahn/projects/llvm-project/clang/lib/Lex/Pragma.cpp:1447:30: note: use '==' to turn this assignment into an equality comparison
 1447 |           if (SpecifierValid = (SpecifierInt != -1))
      |                              ^
      |                              ==
1 warning generated.

We likely need to outer parenthesis as well

diff --git a/clang/lib/Lex/Pragma.cpp b/clang/lib/Lex/Pragma.cpp
index ced407355e00..2972ee2197e2 100644
--- a/clang/lib/Lex/Pragma.cpp
+++ b/clang/lib/Lex/Pragma.cpp
@@ -1444,7 +1444,7 @@ struct PragmaWarningHandler : public PragmaHandler {
                                  .Case("once", PPCallbacks::PWS_Once)
                                  .Case("suppress", PPCallbacks::PWS_Suppress)
                                  .Default(-1);
-          if (SpecifierValid = (SpecifierInt != -1))
+          if ((SpecifierValid = (SpecifierInt != -1)))
             Specifier =
                 static_cast<PPCallbacks::PragmaWarningSpecifier>(SpecifierInt);