[flang][OpenMP] Implement getOpenMPVersion helper function, NFC

[kparzysz]

No description provided.

[llvmbot]

@llvm/pr-subscribers-flang-fir-hlfir

Author: Krzysztof Parzyszek (kparzysz)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/90086.diff

2 Files Affected:

• (modified) flang/lib/Lower/OpenMP/Utils.cpp (+6)
• (modified) flang/lib/Lower/OpenMP/Utils.h (+1)

diff --git a/flang/lib/Lower/OpenMP/Utils.cpp b/flang/lib/Lower/OpenMP/Utils.cpp
index da3f2be73e5095..1400f1f4cc8dd2 100644
--- a/flang/lib/Lower/OpenMP/Utils.cpp
+++ b/flang/lib/Lower/OpenMP/Utils.cpp
@@ -47,6 +47,12 @@ int64_t getCollapseValue(const List<Clause> &clauses) {
   return 1;
 }
 
+uint32_t getOpenMPVersion(mlir::ModuleOp mod) {
+  if (mlir::Attribute verAttr = mod->getAttr("omp.version"))
+    return llvm::cast<mlir::omp::VersionAttr>(verAttr).getVersion();
+  llvm_unreachable("Expecting OpenMP version attribute in module");
+}
+
 void genObjectList(const ObjectList &objects,
                    Fortran::lower::AbstractConverter &converter,
                    llvm::SmallVectorImpl<mlir::Value> &operands) {
diff --git a/flang/lib/Lower/OpenMP/Utils.h b/flang/lib/Lower/OpenMP/Utils.h
index b3a9f7f30c98bd..693a91f7cc6954 100644
--- a/flang/lib/Lower/OpenMP/Utils.h
+++ b/flang/lib/Lower/OpenMP/Utils.h
@@ -59,6 +59,7 @@ void gatherFuncAndVarSyms(
     llvm::SmallVectorImpl<DeclareTargetCapturePair> &symbolAndClause);
 
 int64_t getCollapseValue(const List<Clause> &clauses);
+uint32_t getOpenMPVersion(mlir::ModuleOp mod);
 
 Fortran::semantics::Symbol *
 getOmpObjectSymbol(const Fortran::parser::OmpObject &ompObject);

[kiranchandramohan]

LG.

[tblah]

nit: maybe instead of llvm_unreachable, we could return std::nullopt or some sentinel value. It would be unfortunate if we got into a situation where every mlir file in the test suite needed to have this attribute added to the module.

But it is hard to comment without seeing where this will be used so LGTM whether or not you decide to change.

[tblah]

Thanks!

[skatrak]

Thank you Krzysztof, I have just a small non-blocking comment.

[skatrak]

Nit: Wouldn't it be better placed along with setOpenMPVersionAttribute in flang/include/flang/Tools/CrossToolHelpers.h? And perhaps also call it getOpenMPVersionAttribute for consistency.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.