Skip to content

[AMDGPU][RFC] Combine asm and disasm tests. #90214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion llvm/include/llvm/MC/TargetRegistry.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,11 @@ createAsmStreamer(MCContext &Ctx, std::unique_ptr<formatted_raw_ostream> OS,
bool isVerboseAsm, bool useDwarfDirectory,
MCInstPrinter *InstPrint, std::unique_ptr<MCCodeEmitter> &&CE,
std::unique_ptr<MCAsmBackend> &&TAB, bool ShowInst);

MCStreamer *createHexStreamer(MCContext &Ctx,
std::unique_ptr<formatted_raw_ostream> OS,
MCInstPrinter *InstPrint,
std::unique_ptr<MCCodeEmitter> &&CE,
std::unique_ptr<MCAsmBackend> &&TAB);
MCStreamer *createELFStreamer(MCContext &Ctx,
std::unique_ptr<MCAsmBackend> &&TAB,
std::unique_ptr<MCObjectWriter> &&OW,
Expand Down Expand Up @@ -234,6 +238,9 @@ class Target {
using AsmTargetStreamerCtorTy = MCTargetStreamer *(*)(
MCStreamer &S, formatted_raw_ostream &OS, MCInstPrinter *InstPrint,
bool IsVerboseAsm);
using HexTargetStreamerCtorTy =
MCTargetStreamer *(*)(MCStreamer &S, formatted_raw_ostream &OS,
MCInstPrinter *InstPrint);
using ObjectTargetStreamerCtorTy = MCTargetStreamer *(*)(
MCStreamer &S, const MCSubtargetInfo &STI);
using MCRelocationInfoCtorTy = MCRelocationInfo *(*)(const Triple &TT,
Expand Down Expand Up @@ -346,6 +353,10 @@ class Target {
/// registered (default = nullptr).
AsmTargetStreamerCtorTy AsmTargetStreamerCtorFn = nullptr;

/// Construction function for this target's hex TargetStreamer, if
/// registered (default = nullptr).
HexTargetStreamerCtorTy HexTargetStreamerCtorFn = nullptr;

/// Construction function for this target's obj TargetStreamer, if
/// registered (default = nullptr).
ObjectTargetStreamerCtorTy ObjectTargetStreamerCtorFn = nullptr;
Expand Down Expand Up @@ -671,6 +682,26 @@ class Target {
return nullptr;
}

MCStreamer *createHexStreamer(MCContext &Ctx,
std::unique_ptr<formatted_raw_ostream> OS,
MCInstPrinter *InstPrint,
std::unique_ptr<MCCodeEmitter> &&CE,
std::unique_ptr<MCAsmBackend> &&TAB) const {
formatted_raw_ostream &OSRef = *OS;
MCStreamer *S = llvm::createHexStreamer(Ctx, std::move(OS), InstPrint,
std::move(CE), std::move(TAB));
createHexTargetStreamer(*S, OSRef, InstPrint);
return S;
}

MCTargetStreamer *createHexTargetStreamer(MCStreamer &S,
formatted_raw_ostream &OS,
MCInstPrinter *InstPrint) const {
if (HexTargetStreamerCtorFn)
return HexTargetStreamerCtorFn(S, OS, InstPrint);
return nullptr;
}

/// createMCRelocationInfo - Create a target specific MCRelocationInfo.
///
/// \param TT The target triple.
Expand Down Expand Up @@ -1049,6 +1080,11 @@ struct TargetRegistry {
T.AsmTargetStreamerCtorFn = Fn;
}

static void RegisterHexTargetStreamer(Target &T,
Target::HexTargetStreamerCtorTy Fn) {
T.HexTargetStreamerCtorFn = Fn;
}

static void
RegisterObjectTargetStreamer(Target &T,
Target::ObjectTargetStreamerCtorTy Fn) {
Expand Down
1 change: 1 addition & 0 deletions llvm/lib/MC/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ add_llvm_component_library(LLVMMC
MCExpr.cpp
MCFragment.cpp
MCGOFFStreamer.cpp
MCHexStreamer.cpp
MCInst.cpp
MCInstPrinter.cpp
MCInstrAnalysis.cpp
Expand Down
91 changes: 91 additions & 0 deletions llvm/lib/MC/MCHexStreamer.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
//===- lib/MC/MCHexStreamer.cpp - Hex Output --------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#include "llvm/ADT/StringExtras.h"
#include "llvm/MC/MCAsmBackend.h"
#include "llvm/MC/MCAssembler.h"
#include "llvm/MC/MCCodeEmitter.h"
#include "llvm/MC/MCInstPrinter.h"
#include "llvm/MC/MCObjectWriter.h"
#include "llvm/MC/MCStreamer.h"
#include "llvm/MC/TargetRegistry.h"

using namespace llvm;

namespace {

class MCHexStreamer final : public MCStreamer {
std::unique_ptr<formatted_raw_ostream> OSOwner;
formatted_raw_ostream &OS;
std::unique_ptr<MCInstPrinter> InstPrinter;
std::unique_ptr<MCAssembler> Assembler;

raw_null_ostream NullStream;

public:
MCHexStreamer(MCContext &Context, std::unique_ptr<formatted_raw_ostream> os,
MCInstPrinter *printer, std::unique_ptr<MCCodeEmitter> emitter,
std::unique_ptr<MCAsmBackend> asmbackend)
: MCStreamer(Context), OSOwner(std::move(os)), OS(*OSOwner),
InstPrinter(printer),
Assembler(std::make_unique<MCAssembler>(
Context, std::move(asmbackend), std::move(emitter),
asmbackend ? asmbackend->createObjectWriter(NullStream)
: nullptr)) {
assert(InstPrinter);
}

MCAssembler &getAssembler() { return *Assembler; }

/// @name MCStreamer Interface
/// @{

bool emitSymbolAttribute(MCSymbol *Symbol, MCSymbolAttr Attribute) override {
return true;
}

void emitCommonSymbol(MCSymbol *Symbol, uint64_t Size,
Align ByteAlignment) override {}

void emitZerofill(MCSection *Section, MCSymbol *Symbol = nullptr,
uint64_t Size = 0, Align ByteAlignment = Align(1),
SMLoc Loc = SMLoc()) override {}

void emitInstruction(const MCInst &Inst, const MCSubtargetInfo &STI) override;
};

} // end anonymous namespace.

void MCHexStreamer::emitInstruction(const MCInst &Inst,
const MCSubtargetInfo &STI) {
SmallString<256> Code;
SmallVector<MCFixup, 4> Fixups;
getAssembler().getEmitter().encodeInstruction(Inst, Code, Fixups, STI);

OS << '[';
ListSeparator LS;
for (auto [I, B] : enumerate(Code))
OS << LS << format("0x%02x", B & 0xff);
OS << "] #";

if (getTargetStreamer())
getTargetStreamer()->prettyPrintAsm(*InstPrinter, 0, Inst, STI, OS);
else
InstPrinter->printInst(&Inst, 0, "", STI, OS);

OS << '\n';
}

MCStreamer *llvm::createHexStreamer(MCContext &Context,
std::unique_ptr<formatted_raw_ostream> OS,
MCInstPrinter *IP,
std::unique_ptr<MCCodeEmitter> &&CE,
std::unique_ptr<MCAsmBackend> &&MAB) {
return new MCHexStreamer(Context, std::move(OS), IP, std::move(CE),
std::move(MAB));
}
Loading