Skip to content

Fix a crash introduced by 3d5e9ab by adding a nullptr check. #90301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Fix a crash introduced by 3d5e9ab by adding a nullptr check. #90301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e9d100
Fix a crash introduced by 3d5e9ab by adding a nullptr check.
rniwa Apr 27, 2024
37b5f78
Add a regression test.
rniwa Apr 27, 2024
9a39e45
Override TraverseClassTemplateDecl instead of TraverseDecl.
rniwa Apr 28, 2024
a8cf1f9
Fix formatting.
rniwa Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedCallArgsChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,11 @@ class UncountedCallArgsChecker
bool shouldVisitTemplateInstantiations() const { return true; }
bool shouldVisitImplicitCode() const { return false; }

bool TraverseDecl(Decl *D) {
if (isa<ClassTemplateDecl>(D) && isRefType(safeGetName(D)))
bool TraverseClassTemplateDecl(ClassTemplateDecl *Decl) {
if (isRefType(safeGetName(Decl)))
return true;
return RecursiveASTVisitor<LocalVisitor>::TraverseDecl(D);
return RecursiveASTVisitor<LocalVisitor>::TraverseClassTemplateDecl(
Decl);
}

bool VisitCallExpr(const CallExpr *CE) {
Expand Down
7 changes: 7 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/call-args-regression-traverse-decl-crash.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s
// expected-no-diagnostics

template <class Class> struct T;
template <template <class> class Class, class Type>
struct T<Class<Type>>
{ };