[NFC] Fix hasQualifier comment #90485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operator bool from NestedNameSpecifierLoc and member function hasQualifier both do the same thing, returning true iff the private data member Qualifier is not nullptr, so clearly one of the comments is wrong, and in this case it is the second one.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Jorge Pinto Sousa (sousajo-cc) Changesoperator bool from NestedNameSpecifierLoc and Full diff: https://github.com/llvm/llvm-project/pull/90485.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/NestedNameSpecifier.h b/clang/include/clang/AST/NestedNameSpecifier.h
index 3b6cf972118509..b4ccfa710e5166 100644
--- a/clang/include/clang/AST/NestedNameSpecifier.h
+++ b/clang/include/clang/AST/NestedNameSpecifier.h
@@ -266,7 +266,7 @@ class NestedNameSpecifierLoc {
explicit operator bool() const { return Qualifier; }
/// Evaluates true when this nested-name-specifier location is
- /// empty.
+ /// non-empty.
bool hasQualifier() const { return Qualifier; }
/// Retrieve the nested-name-specifier to which this instance
|
|
fixes #90472 |
shafik
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator bool from NestedNameSpecifierLoc and
member function hasQualifier both do the same thing, returning true iff the private data member Qualifier is not nullptr, so clearly one of the comments is wrong, and in this case it is the second one.
fixes #90472