Skip to content

[BOLT][NFCI] Allow non-simple functions to be in disassembled state #90806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[BOLT][NFCI] Allow non-simple functions to be in disassembled state #90806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions bolt/lib/Core/BinaryFunction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,11 +1437,6 @@ Error BinaryFunction::disassemble() {

clearList(Relocations);

if (!IsSimple) {
clearList(Instructions);
return createNonFatalBOLTError("");
}

updateState(State::Disassembled);

return Error::success();
Expand Down
3 changes: 2 additions & 1 deletion bolt/lib/Rewrite/RewriteInstance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3343,7 +3343,8 @@ void RewriteInstance::disassembleFunctions() {

if (!Function.isSimple()) {
assert((!BC->HasRelocations || Function.getSize() == 0 ||
Function.hasIndirectTargetToSplitFragment()) &&
Function.hasIndirectTargetToSplitFragment() ||
Function.hasInternalCalls()) &&
"unexpected non-simple function in relocation mode");
continue;
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.