Skip to content

[AIX][libc++] Enable clang_modules_include.gen.py tests #90971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024

Conversation

jakeegan
Copy link
Member

@jakeegan jakeegan commented May 3, 2024

Enable these tests on AIX since they're passing.

@jakeegan jakeegan requested a review from daltenty May 3, 2024 14:37
@jakeegan jakeegan requested a review from a team as a code owner May 3, 2024 14:37
Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the CI passes.

@mordante
Copy link
Member

mordante commented May 3, 2024

@jakeegan The CI will fail due to your recent commit 02660e2, which I just reverted in a06c1fe. Next time please test in the CI before committing.

Enable these tests on AIX since they're passing.
@jakeegan jakeegan force-pushed the mod_include_tests branch from 72e6824 to e1bb267 Compare May 6, 2024 16:00
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label May 6, 2024
@llvmbot
Copy link
Member

llvmbot commented May 6, 2024

@llvm/pr-subscribers-libcxx

Author: Jake Egan (jakeegan)

Changes

Enable these tests on AIX since they're passing.


Full diff: https://github.com/llvm/llvm-project/pull/90971.diff

1 Files Affected:

  • (modified) libcxx/test/libcxx/clang_modules_include.gen.py (-6)
diff --git a/libcxx/test/libcxx/clang_modules_include.gen.py b/libcxx/test/libcxx/clang_modules_include.gen.py
index a823a47fd19b50..7ba4bf0326240e 100644
--- a/libcxx/test/libcxx/clang_modules_include.gen.py
+++ b/libcxx/test/libcxx/clang_modules_include.gen.py
@@ -31,9 +31,6 @@
 // UNSUPPORTED: windows
 // UNSUPPORTED: buildhost=windows
 
-// The AIX headers don't appear to be compatible with modules
-// UNSUPPORTED: LIBCXX-AIX-FIXME
-
 // The Android headers don't appear to be compatible with modules yet
 // UNSUPPORTED: LIBCXX-ANDROID-FIXME
 
@@ -61,9 +58,6 @@
 // UNSUPPORTED: windows
 // UNSUPPORTED: buildhost=windows
 
-// The AIX headers don't appear to be compatible with modules
-// UNSUPPORTED: LIBCXX-AIX-FIXME
-
 // The Android headers don't appear to be compatible with modules yet
 // UNSUPPORTED: LIBCXX-ANDROID-FIXME
 

Copy link

github-actions bot commented May 6, 2024

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r 1241e7692a466ceb420be2780f1c3e8bbab7d469...e1bb267aed1be7d4d67826d7b29abb4453932f74 libcxx/test/libcxx/clang_modules_include.gen.py
View the diff from darker here.
--- clang_modules_include.gen.py	2024-05-06 15:56:37.000000 +0000
+++ clang_modules_include.gen.py	2024-05-06 16:02:43.625376 +0000
@@ -18,11 +18,12 @@
 import sys
 sys.path.append(sys.argv[1])
 from libcxx.header_information import lit_header_restrictions, public_headers
 
 for header in public_headers:
-  print(f"""\
+    print(
+        f"""\
 //--- {header}.compile.pass.cpp
 // RUN: %{{cxx}} %s %{{flags}} %{{compile_flags}} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only
 
 // GCC doesn't support -fcxx-modules
 // UNSUPPORTED: gcc
@@ -41,13 +42,15 @@
 // UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
 
 {lit_header_restrictions.get(header, '')}
 
 #include <{header}>
-""")
+"""
+    )
 
-print(f"""\
+print(
+    f"""\
 //--- __std_clang_module.compile.pass.mm
 // RUN: %{{cxx}} %s %{{flags}} %{{compile_flags}} -fmodules -fcxx-modules -fmodules-cache-path=%t -fsyntax-only
 
 // REQUIRES: clang-modules-build
 
@@ -64,6 +67,7 @@
 // TODO: Investigate this failure
 // UNSUPPORTED: LIBCXX-FREEBSD-FIXME
 
 @import std;
 
-""")
+"""
+)

@jakeegan jakeegan merged commit 45fed80 into llvm:main May 7, 2024
@jakeegan jakeegan deleted the mod_include_tests branch May 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants