[Sanitizers] Fix fake_test_gc not working on devices #91284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the LIT RUN command is currently constructed ( %run not --crash %t ) causes the test failure on devices - since 'not' is a LLVM built command, not available on devices. Changing the command to read 'not --crash %run %t' fixes it, as 'not' now executes on the host running the test. rdar://115914588
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Mariusz Borsa (wrotki) ChangesThe way the LIT RUN command is currently constructed ( %run not --crash %t ) causes the test failure on devices - since 'not' is a LLVM built command, not available on devices. Changing the command to read 'not --crash %run %t' fixes it, as 'not' now executes on the host running the test. rdar://115914588 Full diff: https://github.com/llvm/llvm-project/pull/91284.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp b/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp
index 524ca29f2fc577..8c368b9b1b947f 100644
--- a/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp
@@ -1,4 +1,4 @@
-// RUN: %clangxx_asan -O0 -pthread %s -o %t && %env_asan_opts=use_sigaltstack=0 %run not --crash %t 2>&1 | FileCheck %s
+// RUN: %clangxx_asan -O0 -pthread %s -o %t && %env_asan_opts=use_sigaltstack=0 not --crash %run %t 2>&1 | FileCheck %s
// Check that fake stack does not discard frames on the main stack, when GC is
// triggered from high alt stack.
|
wrotki
requested review from
vitalybuka,
thetruestblue,
yln,
rsundahl and
usama54321
thetruestblue
approved these changes
May 8, 2024
|
All other tests in |
yln
approved these changes
May 8, 2024
|
The buildkite test failure is n release_shadow_space.c test from dataflow sanitizer, completely unrelated to this change, so I'm going to merge this. |
wrotki
added a commit
to swiftlang/llvm-project
that referenced
this pull request
May 9, 2024
The way the LIT RUN command is currently constructed ( %run not --crash %t ) causes the test failure on devices - since 'not' is a LLVM built command, not available on devices. Changing the command to read 'not --crash %run %t' fixes it, as 'not' now executes on the host running the test. rdar://115914588 Co-authored-by: Mariusz Borsa <[email protected]> (cherry picked from commit 63c38ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the LIT RUN command is currently constructed ( %run not --crash %t ) causes the test failure on devices - since 'not' is a LLVM built command, not available on devices.
Changing the command to read 'not --crash %run %t' fixes it, as 'not' now executes on the host running the test.
rdar://115914588