-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[RISCV] Move RISCVInsertVSETVLI to after phi elimination #91440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,12 +42,14 @@ | |
; CHECK-NEXT: RISC-V Pre-RA pseudo instruction expansion pass | ||
; CHECK-NEXT: RISC-V Insert Read/Write CSR Pass | ||
; CHECK-NEXT: RISC-V Insert Write VXRM Pass | ||
; CHECK-NEXT: RISC-V Insert VSETVLI pass | ||
; CHECK-NEXT: Init Undef Pass | ||
; CHECK-NEXT: Eliminate PHI nodes for register allocation | ||
; CHECK-NEXT: MachineDominator Tree Construction | ||
; CHECK-NEXT: Slot index numbering | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor, but it looks like maybe one of either two address or fast alloc isn't preserving an analysis that it probably could. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hopefully this is just temporary and will go away once we fully move it to after Fast Register Allocator and before RISC-V Coalesce VSETVLI pass, where it can reuse the live interval analysis there. |
||
; CHECK-NEXT: Live Interval Analysis | ||
; CHECK-NEXT: RISC-V Insert VSETVLI pass | ||
; CHECK-NEXT: Two-Address instruction pass | ||
; CHECK-NEXT: Fast Register Allocator | ||
; CHECK-NEXT: MachineDominator Tree Construction | ||
; CHECK-NEXT: Slot index numbering | ||
; CHECK-NEXT: Live Interval Analysis | ||
; CHECK-NEXT: RISC-V Coalesce VSETVLI pass | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -479,11 +479,11 @@ define <4 x i32> @stest_f16i32(<4 x half> %x) { | |
; CHECK-V-NEXT: addi a0, sp, 16 | ||
; CHECK-V-NEXT: vl1r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 1 | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: csrr a0, vlenb | ||
; CHECK-V-NEXT: add a0, sp, a0 | ||
; CHECK-V-NEXT: addi a0, a0, 16 | ||
; CHECK-V-NEXT: vl2r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 2 | ||
; CHECK-V-NEXT: vsetvli zero, zero, e32, m1, ta, ma | ||
; CHECK-V-NEXT: vnclip.wi v8, v10, 0 | ||
|
@@ -640,11 +640,11 @@ define <4 x i32> @utesth_f16i32(<4 x half> %x) { | |
; CHECK-V-NEXT: addi a0, sp, 16 | ||
; CHECK-V-NEXT: vl1r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 1 | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: csrr a0, vlenb | ||
; CHECK-V-NEXT: add a0, sp, a0 | ||
; CHECK-V-NEXT: addi a0, a0, 16 | ||
; CHECK-V-NEXT: vl2r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 2 | ||
; CHECK-V-NEXT: vsetvli zero, zero, e32, m1, ta, ma | ||
; CHECK-V-NEXT: vnclipu.wi v8, v10, 0 | ||
|
@@ -811,11 +811,11 @@ define <4 x i32> @ustest_f16i32(<4 x half> %x) { | |
; CHECK-V-NEXT: addi a0, sp, 16 | ||
; CHECK-V-NEXT: vl1r.v v9, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vslideup.vi v8, v9, 1 | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: csrr a0, vlenb | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This diff doesn't matter, but is another instance where moving the vsetvli maximally backward would remove a test diff. |
||
; CHECK-V-NEXT: add a0, sp, a0 | ||
; CHECK-V-NEXT: addi a0, a0, 16 | ||
; CHECK-V-NEXT: vl2r.v v10, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: vslideup.vi v8, v10, 2 | ||
; CHECK-V-NEXT: li a0, -1 | ||
; CHECK-V-NEXT: srli a0, a0, 32 | ||
|
@@ -3850,11 +3850,11 @@ define <4 x i32> @stest_f16i32_mm(<4 x half> %x) { | |
; CHECK-V-NEXT: addi a0, sp, 16 | ||
; CHECK-V-NEXT: vl1r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 1 | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: csrr a0, vlenb | ||
; CHECK-V-NEXT: add a0, sp, a0 | ||
; CHECK-V-NEXT: addi a0, a0, 16 | ||
; CHECK-V-NEXT: vl2r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 2 | ||
; CHECK-V-NEXT: vsetvli zero, zero, e32, m1, ta, ma | ||
; CHECK-V-NEXT: vnclip.wi v8, v10, 0 | ||
|
@@ -4009,11 +4009,11 @@ define <4 x i32> @utesth_f16i32_mm(<4 x half> %x) { | |
; CHECK-V-NEXT: addi a0, sp, 16 | ||
; CHECK-V-NEXT: vl1r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 1 | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: csrr a0, vlenb | ||
; CHECK-V-NEXT: add a0, sp, a0 | ||
; CHECK-V-NEXT: addi a0, a0, 16 | ||
; CHECK-V-NEXT: vl2r.v v8, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: vslideup.vi v10, v8, 2 | ||
; CHECK-V-NEXT: vsetvli zero, zero, e32, m1, ta, ma | ||
; CHECK-V-NEXT: vnclipu.wi v8, v10, 0 | ||
|
@@ -4179,11 +4179,11 @@ define <4 x i32> @ustest_f16i32_mm(<4 x half> %x) { | |
; CHECK-V-NEXT: addi a0, sp, 16 | ||
; CHECK-V-NEXT: vl1r.v v9, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vslideup.vi v8, v9, 1 | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: csrr a0, vlenb | ||
; CHECK-V-NEXT: add a0, sp, a0 | ||
; CHECK-V-NEXT: addi a0, a0, 16 | ||
; CHECK-V-NEXT: vl2r.v v10, (a0) # Unknown-size Folded Reload | ||
; CHECK-V-NEXT: vsetivli zero, 4, e64, m2, ta, ma | ||
; CHECK-V-NEXT: vslideup.vi v8, v10, 2 | ||
; CHECK-V-NEXT: li a0, -1 | ||
; CHECK-V-NEXT: srli a0, a0, 32 | ||
|
Uh oh!
There was an error while loading. Please reload this page.