Skip to content

[clang][CodeGen] Remove now-unused FileManager variable #91495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024

Conversation

lamb-j
Copy link
Contributor

@lamb-j lamb-j commented May 8, 2024

Fixes "error: private field 'FileMgr' is not used"

Fixes "error: private field 'FileMgr' is not used"
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:codegen IR generation bugs: mangling, exceptions, etc. labels May 8, 2024
@llvmbot
Copy link
Member

llvmbot commented May 8, 2024

@llvm/pr-subscribers-clang-codegen

Author: Jacob Lambert (lamb-j)

Changes

Fixes "error: private field 'FileMgr' is not used"


Full diff: https://github.com/llvm/llvm-project/pull/91495.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/BackendConsumer.h (-1)
diff --git a/clang/lib/CodeGen/BackendConsumer.h b/clang/lib/CodeGen/BackendConsumer.h
index f9edbe901bb8..7dce21e743f7 100644
--- a/clang/lib/CodeGen/BackendConsumer.h
+++ b/clang/lib/CodeGen/BackendConsumer.h
@@ -34,7 +34,6 @@ class BackendConsumer : public ASTConsumer {
   const CodeGenOptions &CodeGenOpts;
   const TargetOptions &TargetOpts;
   const LangOptions &LangOpts;
-  const FileManager &FileMgr;
   std::unique_ptr<raw_pwrite_stream> AsmOutStream;
   ASTContext *Context;
   IntrusiveRefCntPtr<llvm::vfs::FileSystem> FS;

@llvmbot
Copy link
Member

llvmbot commented May 8, 2024

@llvm/pr-subscribers-clang

Author: Jacob Lambert (lamb-j)

Changes

Fixes "error: private field 'FileMgr' is not used"


Full diff: https://github.com/llvm/llvm-project/pull/91495.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/BackendConsumer.h (-1)
diff --git a/clang/lib/CodeGen/BackendConsumer.h b/clang/lib/CodeGen/BackendConsumer.h
index f9edbe901bb8..7dce21e743f7 100644
--- a/clang/lib/CodeGen/BackendConsumer.h
+++ b/clang/lib/CodeGen/BackendConsumer.h
@@ -34,7 +34,6 @@ class BackendConsumer : public ASTConsumer {
   const CodeGenOptions &CodeGenOpts;
   const TargetOptions &TargetOpts;
   const LangOptions &LangOpts;
-  const FileManager &FileMgr;
   std::unique_ptr<raw_pwrite_stream> AsmOutStream;
   ASTContext *Context;
   IntrusiveRefCntPtr<llvm::vfs::FileSystem> FS;

@lamb-j lamb-j merged commit 3dcbcce into llvm:main May 8, 2024
@lamb-j lamb-j deleted the remove-file-manager branch May 8, 2024 16:42
nhasabni pushed a commit to nhasabni/llvm-project that referenced this pull request May 9, 2024
Fixes "error: private field 'FileMgr' is not used" introduced by 11a6799
nhasabni pushed a commit to nhasabni/llvm-project that referenced this pull request May 9, 2024
Fixes "error: private field 'FileMgr' is not used" introduced by 11a6799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants