[lldb] Fix redundant condition in Target.cpp #91882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue llvm#87244, where a redundant condition was found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the Target.cpp file
|
@llvm/pr-subscribers-lldb Author: None (aabhinavg) ChangesThis commit addresses issue #87244, where a redundant condition was found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the Target.cpp file Full diff: https://github.com/llvm/llvm-project/pull/91882.diff 1 Files Affected:
diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp
index 82f3040e539a3..fe87728a33dc8 100644
--- a/lldb/source/Target/Target.cpp
+++ b/lldb/source/Target/Target.cpp
@@ -841,12 +841,14 @@ static bool CheckIfWatchpointsSupported(Target *target, Status &error) {
if (!num_supported_hardware_watchpoints)
return true;
- if (num_supported_hardware_watchpoints == 0) {
- error.SetErrorStringWithFormat(
- "Target supports (%u) hardware watchpoint slots.\n",
- *num_supported_hardware_watchpoints);
- return false;
- }
+ // If num_supported_hardware_watchpoints is zero, set an
+ //error message and return false.
+
+ error.SetErrorStringWithFormat(
+ "Target supports (%u) hardware watchpoint slots.\n",
+ *num_supported_hardware_watchpoints);
+ return false;
+
return true;
}
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
DavidSpickett
requested changes
May 13, 2024
This reverts commit 9b41609. The CheckIfWatchpointsSupported function is refactored to maintain the intended behavior as described below: 1. If we can't detect hardware watchpoints, assume they are supported. 2. If we can detect hardware watchpoints and there are more than 0, return true. 3. If we can detect hardware watchpoints but there are 0 of them, set an error message and return false. fix llvm#87244
aabhinavg
force-pushed
the
fix-watchpoint-issue
branch
from
9c543a6 to
421b4ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #87244, where a redundant condition was found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the Target.cpp file
fix #87244