Skip to content

[OpenMP][MLIR] Fix llvm::sort comparator. #91947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

[OpenMP][MLIR] Fix llvm::sort comparator. #91947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2175,10 +2175,10 @@ getFirstOrLastMappedMemberPtr(mlir::omp::MapInfoOp mapInfo, bool first) {
return !first;
}

// iterated the entire list and couldn't make a decision, all elements
// were likely the same, return true for now similar to reaching the end
// of both and finding invalid indices.
return true;
// Iterated the entire list and couldn't make a decision, all elements
// were likely the same. Return false, since the sort comparator should
// return false for equal elements.
return false;
});

return llvm::cast<mlir::omp::MapInfoOp>(
Expand Down
Loading