Skip to content

[libc][docs] Fix outdated code review section, as per #91934 #92051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2024
Merged

[libc][docs] Fix outdated code review section, as per #91934 #92051

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
425336b
[libc][docs] Fix outdated code review section, as per #91934
cyuria May 13, 2024
233de7a
Merge branch 'main' into patch-1
cyuria May 14, 2024
d75cba4
Merge branch 'main' into patch-1
cyuria May 15, 2024
0a0c3da
Merge branch 'main' into patch-1
cyuria May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libc/src/math/docs/add_math_function.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ implementation (which is very often glibc).

## Code reviews

We follow the code review process of LLVM with Phabricator:
We use GitHub's inbuilt pull request system for code review:
```
https://llvm.org/docs/Phabricator.html
https://docs.github.com/articles/about-collaborative-development-models
https://docs.github.com/articles/about-pull-requests
```
Loading