Skip to content

[lldb] Fixed the TestCompletion test running on a remote target #92281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lldb/test/API/functionalities/completion/TestCompletion.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,16 @@ def test_process_unload(self):
self, "// Break here", lldb.SBFileSpec("main.cpp")
)
err = lldb.SBError()
self.process().LoadImage(
lldb.SBFileSpec(self.getBuildArtifact("libshared.so")), err
local_spec = lldb.SBFileSpec(self.getBuildArtifact("libshared.so"))
remote_spec = (
lldb.SBFileSpec(
lldbutil.append_to_process_working_directory(self, "libshared.so"),
False,
)
if lldb.remote_platform
else lldb.SBFileSpec()
)
self.process().LoadImage(local_spec, remote_spec, err)
self.assertSuccess(err)

self.complete_from_to("process unload ", "process unload 0")
Expand Down Expand Up @@ -473,7 +480,7 @@ def test_custom_command_completion(self):
self.complete_from_to("my_test_cmd main.cp", ["main.cpp"])
self.expect("my_test_cmd main.cpp", substrs=["main.cpp"])

@skipIfWindows
@skipIf(hostoslist=["windows"])
def test_completion_target_create_from_root_dir(self):
"""Tests source file completion by completing ."""
root_dir = os.path.abspath(os.sep)
Expand Down
Loading