[lldb] Fixed an invalid error message in the DAP disconnect response #92345
Conversation
The `disconnect` response contains the `error` message with invalid characters (a junk data). To reproduce this issue it is enough to run the TestDAP_commands test on Windows host and Linux target. The test will fail to run ELF file on Windows and dap_server will be disconnected unexpectedly. Note dap_server hangs if read_packet() cannot decode JSON with invalid characters. read_packet() must return None in this case instead of an exception. But dap_server does not require any fix after this patch.
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesThe Note dap_server hangs if read_packet() cannot decode JSON with invalid characters. read_packet() must return None in this case instead of an exception. But dap_server does not require any fix after this patch. Full diff: https://github.com/llvm/llvm-project/pull/92345.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/lldb-dap.cpp b/lldb/tools/lldb-dap/lldb-dap.cpp
index 96da458be21d1..e9810f83678eb 100644
--- a/lldb/tools/lldb-dap/lldb-dap.cpp
+++ b/lldb/tools/lldb-dap/lldb-dap.cpp
@@ -977,7 +977,7 @@ void request_disconnect(const llvm::json::Object &request) {
g_dap.debugger.SetAsync(false);
lldb::SBError error = terminateDebuggee ? process.Kill() : process.Detach();
if (!error.Success())
- response.try_emplace("error", error.GetCString());
+ response.try_emplace("error", std::string(error.GetCString()));
g_dap.debugger.SetAsync(true);
break;
}
|
lldb/tools/lldb-dap/lldb-dap.cpp
Outdated
| @@ -977,7 +977,7 @@ void request_disconnect(const llvm::json::Object &request) { | |||
| g_dap.debugger.SetAsync(false); | |||
| lldb::SBError error = terminateDebuggee ? process.Kill() : process.Detach(); | |||
| if (!error.Success()) | |||
| response.try_emplace("error", error.GetCString()); | |||
| response.try_emplace("error", std::string(error.GetCString())); | |||
There was a problem hiding this comment.
EmplaceSafeString sounds like the right thing to use here.
There was a problem hiding this comment.
I have updated the patch. Thanks.
The
disconnectresponse contains theerrormessage with invalid characters (a junk data). To reproduce this issue it is enough to run theTestDAP_commandstest on Windows host and Linux target. The test will fail to run ELF file on Windows and dap_server will be disconnected unexpectedly.Note dap_server hangs if read_packet() cannot decode JSON with invalid characters. read_packet() must return None in this case instead of an exception. But dap_server does not require any fix after this patch.