Skip to content

[lldb] Fixed the DAP tests in case of a remote target #92398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

slydiman
Copy link
Contributor

These tests failed in case of Windows host and Linux target, because dap_server tried to run ELF file on Windows.

These tests failed in case of Windows host and Linux target, because dap_server tried to run ELF file on Windows.
@slydiman slydiman requested a review from JDevlieghere as a code owner May 16, 2024 13:23
@llvmbot llvmbot added the lldb label May 16, 2024
@slydiman slydiman requested review from DavidSpickett and labath May 16, 2024 13:24
@llvmbot
Copy link
Member

llvmbot commented May 16, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

These tests failed in case of Windows host and Linux target, because dap_server tried to run ELF file on Windows.


Full diff: https://github.com/llvm/llvm-project/pull/92398.diff

2 Files Affected:

  • (modified) lldb/test/API/tools/lldb-dap/commands/TestDAP_commands.py (+2)
  • (modified) lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py (+1)
diff --git a/lldb/test/API/tools/lldb-dap/commands/TestDAP_commands.py b/lldb/test/API/tools/lldb-dap/commands/TestDAP_commands.py
index 226b9385fe719..bfdf9ef2897b2 100644
--- a/lldb/test/API/tools/lldb-dap/commands/TestDAP_commands.py
+++ b/lldb/test/API/tools/lldb-dap/commands/TestDAP_commands.py
@@ -7,6 +7,7 @@
 
 
 class TestDAP_commands(lldbdap_testcase.DAPTestCaseBase):
+    @skipIfRemote
     def test_command_directive_quiet_on_success(self):
         program = self.getBuildArtifact("a.out")
         command_quiet = (
@@ -60,6 +61,7 @@ def test_command_directive_abort_on_error_launch_commands(self):
     def test_command_directive_abort_on_error_pre_run_commands(self):
         self.do_test_abort_on_error(use_pre_run_commands=True)
 
+    @skipIfRemote
     def test_command_directive_abort_on_error_post_run_commands(self):
         self.do_test_abort_on_error(use_post_run_commands=True)
 
diff --git a/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py b/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py
index fd48e69cae5e2..7700c65f862dc 100644
--- a/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py
+++ b/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py
@@ -11,6 +11,7 @@
 
 
 class TestDAP_startDebugging(lldbdap_testcase.DAPTestCaseBase):
+    @skipIfRemote
     def test_startDebugging(self):
         """
         Tests the "startDebugging" reverse request. It makes sure that the IDE can

@slydiman slydiman merged commit d665d51 into llvm:main May 16, 2024
6 checks passed
@slydiman slydiman deleted the fix-lldb-dap-tests branch July 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants