[lldb] Fixed the test TestGdbRemoteAttachWait running on a remote target #92413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install `_exe_to_attach` to a remote target if necessary.
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesInstall Full diff: https://github.com/llvm/llvm-project/pull/92413.diff 1 Files Affected:
diff --git a/lldb/test/API/tools/lldb-server/attach-wait/TestGdbRemoteAttachWait.py b/lldb/test/API/tools/lldb-server/attach-wait/TestGdbRemoteAttachWait.py
index f4c31fe2f5c07..a8333210a72b1 100644
--- a/lldb/test/API/tools/lldb-server/attach-wait/TestGdbRemoteAttachWait.py
+++ b/lldb/test/API/tools/lldb-server/attach-wait/TestGdbRemoteAttachWait.py
@@ -52,6 +52,9 @@ def test_attach_with_vAttachWait(self):
server = self.connect_to_debug_monitor()
self.do_handshake()
+ if self._run_args:
+ self._run_args[0] = lldbutil.install_to_target(self, self._run_args[0])
+
# Launch the first inferior (we shouldn't attach to this one).
self._launch_and_wait_for_init()
@@ -101,6 +104,9 @@ def test_launch_before_attach_with_vAttachOrWait(self):
server = self.connect_to_debug_monitor()
self.do_handshake()
+ if self._run_args:
+ self._run_args[0] = lldbutil.install_to_target(self, self._run_args[0])
+
inferior = self._launch_and_wait_for_init()
# Add attach packets.
@@ -141,6 +147,9 @@ def test_launch_after_attach_with_vAttachOrWait(self):
server = self.connect_to_debug_monitor()
self.do_handshake()
+ if self._run_args:
+ self._run_args[0] = lldbutil.install_to_target(self, self._run_args[0])
+
self.test_sequence.add_log_lines([self._attach_packet("vAttachOrWait")], True)
# Run the stream until attachWait.
context = self.expect_gdbremote_sequence()
|
labath
reviewed
May 17, 2024
| @@ -52,6 +52,9 @@ def test_attach_with_vAttachWait(self): | |||
| server = self.connect_to_debug_monitor() | |||
| self.do_handshake() | |||
|
|
|||
| if self._run_args: | |||
| self._run_args[0] = lldbutil.install_to_target(self, self._run_args[0]) | |||
There was a problem hiding this comment.
Please do this inside _set_up_inferior, before assigning to _run_args
There was a problem hiding this comment.
I have updated the patch. Thanks.
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Jun 5, 2024
…731b835aa Local branch amd-gfx 2b2731b Merged main:30d0850e0f780b17a37522e6503c98ebe197c5fa into amd-gfx:c4099e191a09 Remote branch main d38ea8c [lldb] Fixed the test TestGdbRemoteAttachWait running on a remote target (llvm#92413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install
_exe_to_attachto a remote target if necessary.