[MLIR Attr] add ArrayMaxCount attribute constraint #92453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosy
changed the title
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core Author: Ryan Thomas Lynch (emosy) Changesthis is the dual of ArrayMinCount. I saw that I needed it but it didn't exist yet Full diff: https://github.com/llvm/llvm-project/pull/92453.diff 1 Files Affected:
diff --git a/mlir/include/mlir/IR/CommonAttrConstraints.td b/mlir/include/mlir/IR/CommonAttrConstraints.td
index 0d69bb0717a59..d99bde1f87ef0 100644
--- a/mlir/include/mlir/IR/CommonAttrConstraints.td
+++ b/mlir/include/mlir/IR/CommonAttrConstraints.td
@@ -773,6 +773,10 @@ def IntPositive : AttrConstraint<
CPred<"::llvm::cast<::mlir::IntegerAttr>($_self).getValue().isStrictlyPositive()">,
"whose value is positive">;
+class ArrayMaxCount<int n> : AttrConstraint<
+ CPred<"::llvm::cast<::mlir::ArrayAttr>($_self).size() <= " # n>,
+ "with at most " # n # " elements">;
+
class ArrayMinCount<int n> : AttrConstraint<
CPred<"::llvm::cast<::mlir::ArrayAttr>($_self).size() >= " # n>,
"with at least " # n # " elements">;
|
joker-eph
approved these changes
May 16, 2024
this is the dual of ArrayMinCount. I saw that I needed it but it didn't exist yet
emosy
force-pushed
the
mlir/attr/arraymaxcount
branch
from
89d7718 to
8d97179
Compare
|
@joker-eph Thanks! I also made some changes to Operations.md Feel free to merge the PR when ready |
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Jun 5, 2024
…f282b2831 Local branch amd-gfx f40f282 Merged main:d311a62e2f1ae34a0329c3812f2969cedac93561 into amd-gfx:3c31da5ad733 Remote branch main e578314 [MLIR Attr] add ArrayMaxCount attribute constraint (llvm#92453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the dual of ArrayMinCount. I saw that I needed it but it didn't exist yet