[flang][cuda] Fix memory side effects on cuf.data_transfer op

[clementval]

The memory side effects on the cuf.data_transfer operation were swapped between the src and dst operands. We read from source and write to destination not the opposite.

[llvmbot]

@llvm/pr-subscribers-flang-fir-hlfir

Author: Valentin Clement (バレンタイン クレメン) (clementval)

Changes

The memory side effects on the cuf.data_transfer operation were swapped between the src and dst operands. We read from source and write to destination not the opposite.

---

Full diff: https://github.com/llvm/llvm-project/pull/92928.diff

1 Files Affected:

• (modified) flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td (+2-2)

diff --git a/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td b/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td
index 72157bce4f768..1c98b4131a139 100644
--- a/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td
+++ b/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td
@@ -154,8 +154,8 @@ def cuf_DataTransferOp : cuf_Op<"data_transfer", []> {
     ```
   }];
 
-  let arguments = (ins Arg<AnyReferenceLike, "", [MemWrite]>:$src,
-                       Arg<AnyReferenceLike, "", [MemRead]>:$dst,
+  let arguments = (ins Arg<AnyReferenceLike, "", [MemRead]>:$src,
+                       Arg<AnyReferenceLike, "", [MemWrite]>:$dst,
                        cuf_DataTransferKindAttr:$transfer_kind);
 
   let assemblyFormat = [{

[vzakhari]

Oops, I missed that. Thank you!

[clementval]

Oops, I missed that. Thank you!

It's because I starred at the op for a while that I found it. :-)