Skip to content

[nfc][InstrProfWriter]Wrap vtable writes in a method. #93081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

[nfc][InstrProfWriter]Wrap vtable writes in a method. #93081

merged 1 commit into from
May 23, 2024

Conversation

mingmingl-llvm
Copy link
Contributor

@mingmingl-llvm mingmingl-llvm commented May 22, 2024 •
edited
Loading

  • This way InstrProfWriter::writeImpl itself is simpler.

@mingmingl-llvm
[nfc][InstrProfWriter]Wrap vtable writes in a method.
771773d 
- This way InstrProfWriter::writeImpl itself is simpler.
kazutakahirata
kazutakahirata approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making writeImpl smaller! LGTM.

@mingmingl-llvm
Copy link
Contributor Author

thanks!

@mingmingl-llvm mingmingl-llvm merged commit beac910 into llvm:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazutakahirata kazutakahirata kazutakahirata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingmingl-llvm @kazutakahirata