Fix update-test-checks.py on Python 3.6

[efriedma-quic]

re.Match apparently doesn't exist in older versions.

[llvmbot]

@llvm/pr-subscribers-testing-tools

Author: Eli Friedman (efriedma-quic)

Changes

re.Match apparently doesn't exist in older versions.

---

Full diff: https://github.com/llvm/llvm-project/pull/93116.diff

1 Files Affected:

• (modified) llvm/utils/UpdateTestChecks/common.py (+1-1)

diff --git a/llvm/utils/UpdateTestChecks/common.py b/llvm/utils/UpdateTestChecks/common.py
index 7da16e0f0cb2e..85c129488d950 100644
--- a/llvm/utils/UpdateTestChecks/common.py
+++ b/llvm/utils/UpdateTestChecks/common.py
@@ -1041,7 +1041,7 @@ def get_value_name(self, var: str, check_prefix: str):
         var = var.replace("-", "_")
         return var.upper()
 
-    def get_affixes_from_match(self, match: re.Match):
+    def get_affixes_from_match(self, match):
         prefix = re.match(self.ir_prefix, match.group(2)).group(0)
         suffix = re.search(self.ir_suffix + "$", match.group(2)).group(0)
         return prefix, suffix

[jh7370]

Python 3.6 reached end of life in December 2021, so well over 2 years ago. Do we really need to support it? Is updating to a newer python not an option in this case?

[efriedma-quic]

Do we really need to support it?

I could probably upgrade my Python my builds use personally. But the documentation still says 3.6, and the build system still enforces 3.6, so we should support 3.6 as long as that's true. If you want to change the minimum, please start a Discourse thread.