Skip to content

[lldb] Fixed the TestExitDuringExpression test in case of a remote target #93119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

slydiman
Copy link
Contributor

Sometimes this test failed on the assert The thread exited in case of a remote target. Increase the timeout to 1 second to avoid a racing condition.

…rget

Sometimes this test failed on the assert `The thread exited` in case of a remote target. Increase the timeout to 1 second to avoid a racing condition.
@slydiman slydiman requested a review from JDevlieghere as a code owner May 23, 2024 00:57
@llvmbot llvmbot added the lldb label May 23, 2024
@slydiman slydiman requested a review from labath May 23, 2024 00:57
@llvmbot
Copy link
Member

llvmbot commented May 23, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

Sometimes this test failed on the assert The thread exited in case of a remote target. Increase the timeout to 1 second to avoid a racing condition.


Full diff: https://github.com/llvm/llvm-project/pull/93119.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/thread/exit_during_expression/main.c (+1-1)
diff --git a/lldb/test/API/functionalities/thread/exit_during_expression/main.c b/lldb/test/API/functionalities/thread/exit_during_expression/main.c
index eb6d17520986c..f633632e96cc4 100644
--- a/lldb/test/API/functionalities/thread/exit_during_expression/main.c
+++ b/lldb/test/API/functionalities/thread/exit_during_expression/main.c
@@ -3,7 +3,7 @@
 #include <stdio.h>
 #include <unistd.h>
 
-static unsigned int g_timeout = 100000;
+static unsigned int g_timeout = 1000000;
 
 extern int usleep(unsigned int);
 

@slydiman slydiman requested a review from DavidSpickett May 23, 2024 00:58
@slydiman slydiman merged commit e37da2c into llvm:main May 23, 2024
6 checks passed
@slydiman slydiman deleted the fix-lldb-test-TestExitDuringExpression branch July 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants