[memprof] Refactor getMemProfRecord (NFC) #93138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch refactors getMemProfRecord for readability while adding consistency checks. - This patch adds a switch statement on the MemProf version just like most places dealing with MemProf serialization/deserialization. - This patch adds asserts to ensure that the exact set of data structures are available while ones we do not use are not present. That is, getMemProfRecord no longer determines the version based on the availability of MemProfCallStackTable.
snehasish
reviewed
May 23, 2024
|
Thank you for the review! I've addressed comments. Please take a look again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors getMemProfRecord for readability while adding
consistency checks.
This patch adds a switch statement on the MemProf version just like
most places dealing with MemProf serialization/deserialization.
This patch adds asserts to ensure that the exact set of data
structures are available while ones we do not use are not present.
That is, getMemProfRecord no longer determines the version based on
the availability of MemProfCallStackTable.