Skip to content

[WindowsManifestMerger] Remove deprecated call to xmlKeepBlanksDefault #93139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024

Conversation

nikic
Copy link
Contributor

@nikic nikic commented May 23, 2024

This function has been deprecated in favor of the XML_PARSE_NOBLANKS option. The code already uses the option, so remove the call. If this call served some additional purpose, then it wasn't tested.

Fixes #86029.

This function has been deprecated in favor of the XML_PARSE_NOBLANKS
option. The code already uses the option, so remove the call. If
this call served some additional purpose, then it wasn't tested.
@nikic nikic requested a review from rnk May 23, 2024 05:52
@nikic nikic merged commit dbfed77 into llvm:main May 27, 2024
4 checks passed
@nikic nikic deleted the libxml-deprecation branch May 27, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm/lib/WindowsManifest/WindowsManifestMerger.cpp: xmlKeepBlanksDefault is deprecated API
2 participants