Skip to content

[lldb] Fixed the TestDAP_repl_mode_detection test in case of a remote target #93165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

slydiman
Copy link
Contributor

This test is based on dap_server which runs locally. This test failed in case of Windows host and Linux target.

… target

This test is based on dap_server which runs locally. This test failed in case of Windows host and Linux target.
@slydiman slydiman requested a review from labath May 23, 2024 10:22
@slydiman slydiman requested a review from JDevlieghere as a code owner May 23, 2024 10:22
@llvmbot llvmbot added the lldb label May 23, 2024
@llvmbot
Copy link
Member

llvmbot commented May 23, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

This test is based on dap_server which runs locally. This test failed in case of Windows host and Linux target.


Full diff: https://github.com/llvm/llvm-project/pull/93165.diff

1 Files Affected:

  • (modified) lldb/test/API/tools/lldb-dap/repl-mode/TestDAP_repl_mode_detection.py (+1)
diff --git a/lldb/test/API/tools/lldb-dap/repl-mode/TestDAP_repl_mode_detection.py b/lldb/test/API/tools/lldb-dap/repl-mode/TestDAP_repl_mode_detection.py
index 7c77fc8541b93..705ae13e349dc 100644
--- a/lldb/test/API/tools/lldb-dap/repl-mode/TestDAP_repl_mode_detection.py
+++ b/lldb/test/API/tools/lldb-dap/repl-mode/TestDAP_repl_mode_detection.py
@@ -18,6 +18,7 @@ def assertEvaluate(self, expression, regex):
             regex,
         )
 
+    @skipIfRemote
     def test_completions(self):
         program = self.getBuildArtifact("a.out")
         self.build_and_launch(program)

Copy link
Collaborator

@labath labath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm knee-deep in lldb-dap right now. Lemme just send you a PR to skip all tests at once.

@slydiman
Copy link
Contributor Author

Replaced by #93169.

@slydiman slydiman closed this May 24, 2024
@slydiman slydiman deleted the fix-lldb-test-TestDAP_repl_mode_detection branch July 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants