Skip to content

[mlir] expose -debug-only equivalent to C and Python #93175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mlir/include/mlir-c/Debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@ MLIR_CAPI_EXPORTED void mlirEnableGlobalDebug(bool enable);
/// Retuns `true` if the global debugging flag is set, false otherwise.
MLIR_CAPI_EXPORTED bool mlirIsGlobalDebugEnabled();

/// Sets the current debug type, similarly to `-debug-only=type` in the
/// command-line tools. Note that global debug should be enabled for any output
/// to be produced.
MLIR_CAPI_EXPORTED void mlirSetGlobalDebugType(const char *type);

/// Sets multiple current debug types, similarly to `-debug-only=type1,type2" in
/// the command-line tools. Note that global debug should be enabled for any
/// output to be produced.
MLIR_CAPI_EXPORTED void mlirSetGlobalDebugTypes(const char **types, intptr_t n);

/// Checks if `type` is set as the current debug type.
MLIR_CAPI_EXPORTED bool mlirIsCurrentDebugType(const char *type);

#ifdef __cplusplus
}
#endif
Expand Down
15 changes: 14 additions & 1 deletion mlir/lib/Bindings/Python/IRCore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,20 @@ struct PyGlobalDebugFlag {
// Debug flags.
py::class_<PyGlobalDebugFlag>(m, "_GlobalDebug", py::module_local())
.def_property_static("flag", &PyGlobalDebugFlag::get,
&PyGlobalDebugFlag::set, "LLVM-wide debug flag");
&PyGlobalDebugFlag::set, "LLVM-wide debug flag")
.def_static(
"set_types",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this only sets on type?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is an overload. whoops.

[](const std::string &type) {
mlirSetGlobalDebugType(type.c_str());
},
"types"_a, "Sets specific debug types to be produced by LLVM")
.def_static("set_types", [](const std::vector<std::string> &types) {
std::vector<const char *> pointers;
pointers.reserve(types.size());
for (const std::string &str : types)
pointers.push_back(str.c_str());
mlirSetGlobalDebugTypes(pointers.data(), pointers.size());
});
}
};

Expand Down
18 changes: 18 additions & 0 deletions mlir/lib/CAPI/Debug/Debug.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,21 @@
void mlirEnableGlobalDebug(bool enable) { llvm::DebugFlag = enable; }

bool mlirIsGlobalDebugEnabled() { return llvm::DebugFlag; }

void mlirSetGlobalDebugType(const char *type) {
// Depending on the NDEBUG flag, this name can be either a function or a macro
// that expands to something that isn't a funciton call, so we cannot
// explicitly prefix it with `llvm::` or declare `using` it.
using namespace llvm;
setCurrentDebugType(type);
}

void mlirSetGlobalDebugTypes(const char **types, intptr_t n) {
using namespace llvm;
setCurrentDebugTypes(types, n);
}

bool mlirIsCurrentDebugType(const char *type) {
using namespace llvm;
return isCurrentDebugType(type);
}
Loading