-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[AMDGPU][test] Fix the wrong triples in lower-work-group-id-intrinsics-{hsa,pal}.ll. NFC #93501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py | ||
; RUN: llc -mtriple=amdgcn-amd-hsa -mcpu=gfx900 -mattr=-architected-sgprs -global-isel=0 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9 %s | ||
; RUN: llc -mtriple=amdgcn-amd-hsa -mcpu=gfx900 -mattr=-architected-sgprs -global-isel=1 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9 %s | ||
; RUN: llc -mtriple=amdgcn-amd-hsa -mcpu=gfx900 -mattr=+architected-sgprs -global-isel=0 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9ARCH-SDAG %s | ||
; RUN: llc -mtriple=amdgcn-amd-hsa -mcpu=gfx900 -mattr=+architected-sgprs -global-isel=1 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9ARCH-GISEL %s | ||
Comment on lines
-2
to
-5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These probably were intended to be amdgcn-amd-amdpal, there is lost coverage here now without flipping the architecture-sgprs feature There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it should be. I have recovered them and changed to |
||
; RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx900 -mattr=-architected-sgprs -global-isel=0 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9 %s | ||
; RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx900 -mattr=-architected-sgprs -global-isel=1 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9 %s | ||
; RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx900 -mattr=+architected-sgprs -global-isel=0 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9ARCH-SDAG %s | ||
; RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx900 -mattr=+architected-sgprs -global-isel=1 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9ARCH-GISEL %s | ||
; RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx1200 -global-isel=0 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX12,GFX12-SDAG %s | ||
; RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx1200 -global-isel=1 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX12,GFX12-GISEL %s | ||
|
||
|
@@ -67,62 +67,37 @@ define amdgpu_cs void @_amdgpu_cs_main() { | |
} | ||
|
||
define amdgpu_cs void @caller() { | ||
; GFX9-LABEL: caller: | ||
; GFX9: ; %bb.0: | ||
; GFX9-NEXT: s_mov_b32 s8, SCRATCH_RSRC_DWORD0 | ||
; GFX9-NEXT: s_mov_b32 s9, SCRATCH_RSRC_DWORD1 | ||
; GFX9-NEXT: s_mov_b32 s10, -1 | ||
; GFX9-NEXT: s_mov_b32 s11, 0xe00000 | ||
; GFX9-NEXT: s_add_u32 s8, s8, s0 | ||
; GFX9-NEXT: s_addc_u32 s9, s9, 0 | ||
; GFX9-NEXT: s_getpc_b64 s[0:1] | ||
; GFX9-NEXT: s_add_u32 s0, s0, callee@gotpcrel32@lo+4 | ||
; GFX9-NEXT: s_addc_u32 s1, s1, callee@gotpcrel32@hi+12 | ||
; GFX9-NEXT: s_load_dwordx2 s[4:5], s[0:1], 0x0 | ||
; GFX9-NEXT: s_mov_b64 s[0:1], s[8:9] | ||
; GFX9-NEXT: s_mov_b64 s[2:3], s[10:11] | ||
; GFX9-NEXT: s_mov_b32 s32, 0 | ||
; GFX9-NEXT: s_waitcnt lgkmcnt(0) | ||
; GFX9-NEXT: s_swappc_b64 s[30:31], s[4:5] | ||
; GFX9-NEXT: s_endpgm | ||
; | ||
; GFX9ARCH-SDAG-LABEL: caller: | ||
; GFX9ARCH-SDAG: ; %bb.0: | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s8, SCRATCH_RSRC_DWORD0 | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s9, SCRATCH_RSRC_DWORD1 | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s10, -1 | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s11, 0xe00000 | ||
; GFX9ARCH-SDAG-NEXT: s_getpc_b64 s[8:9] | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s8, s0 | ||
; GFX9ARCH-SDAG-NEXT: s_load_dwordx4 s[8:11], s[8:9], 0x10 | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s5, callee@abs32@hi | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s4, callee@abs32@lo | ||
; GFX9ARCH-SDAG-NEXT: v_mov_b32_e32 v0, ttmp9 | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s32, 0 | ||
; GFX9ARCH-SDAG-NEXT: s_waitcnt lgkmcnt(0) | ||
; GFX9ARCH-SDAG-NEXT: s_add_u32 s8, s8, s0 | ||
; GFX9ARCH-SDAG-NEXT: s_addc_u32 s9, s9, 0 | ||
; GFX9ARCH-SDAG-NEXT: s_getpc_b64 s[0:1] | ||
; GFX9ARCH-SDAG-NEXT: s_add_u32 s0, s0, callee@gotpcrel32@lo+4 | ||
; GFX9ARCH-SDAG-NEXT: s_addc_u32 s1, s1, callee@gotpcrel32@hi+12 | ||
; GFX9ARCH-SDAG-NEXT: s_load_dwordx2 s[4:5], s[0:1], 0x0 | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b64 s[0:1], s[8:9] | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b64 s[2:3], s[10:11] | ||
; GFX9ARCH-SDAG-NEXT: v_mov_b32_e32 v0, ttmp9 | ||
; GFX9ARCH-SDAG-NEXT: s_mov_b32 s32, 0 | ||
; GFX9ARCH-SDAG-NEXT: s_waitcnt lgkmcnt(0) | ||
; GFX9ARCH-SDAG-NEXT: s_swappc_b64 s[30:31], s[4:5] | ||
; GFX9ARCH-SDAG-NEXT: s_endpgm | ||
; | ||
; GFX9ARCH-GISEL-LABEL: caller: | ||
; GFX9ARCH-GISEL: ; %bb.0: | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s8, SCRATCH_RSRC_DWORD0 | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s9, SCRATCH_RSRC_DWORD1 | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s10, -1 | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s11, 0xe00000 | ||
; GFX9ARCH-GISEL-NEXT: s_getpc_b64 s[8:9] | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s8, s0 | ||
; GFX9ARCH-GISEL-NEXT: s_load_dwordx4 s[8:11], s[8:9], 0x10 | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s4, callee@abs32@lo | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s5, callee@abs32@hi | ||
; GFX9ARCH-GISEL-NEXT: v_mov_b32_e32 v0, ttmp9 | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s32, 0 | ||
; GFX9ARCH-GISEL-NEXT: s_waitcnt lgkmcnt(0) | ||
; GFX9ARCH-GISEL-NEXT: s_add_u32 s8, s8, s0 | ||
; GFX9ARCH-GISEL-NEXT: s_addc_u32 s9, s9, 0 | ||
; GFX9ARCH-GISEL-NEXT: s_getpc_b64 s[0:1] | ||
; GFX9ARCH-GISEL-NEXT: s_add_u32 s0, s0, callee@gotpcrel32@lo+4 | ||
; GFX9ARCH-GISEL-NEXT: s_addc_u32 s1, s1, callee@gotpcrel32@hi+12 | ||
; GFX9ARCH-GISEL-NEXT: s_load_dwordx2 s[4:5], s[0:1], 0x0 | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b64 s[0:1], s[8:9] | ||
; GFX9ARCH-GISEL-NEXT: v_mov_b32_e32 v0, ttmp9 | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b64 s[2:3], s[10:11] | ||
; GFX9ARCH-GISEL-NEXT: s_mov_b32 s32, 0 | ||
; GFX9ARCH-GISEL-NEXT: s_waitcnt lgkmcnt(0) | ||
; GFX9ARCH-GISEL-NEXT: s_swappc_b64 s[30:31], s[4:5] | ||
; GFX9ARCH-GISEL-NEXT: s_endpgm | ||
; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests should not be deleted. If the error is emitted, the test file should be split up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that had been split into llvm/test/CodeGen/AMDGPU/lower-work-group-id-intrinsics-{hsa,pal}.ll.