Skip to content

[polly] Fix cppcheck SA comment reported in #91235 #93505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

kartcq
Copy link
Contributor

@kartcq kartcq commented May 28, 2024

This patch moves the unreachable assert before return statement.
Fixes #91235.

This patch moves the unreachable assert before return statement.
Fixes llvm#91235.
@kartcq
Copy link
Contributor Author

kartcq commented May 28, 2024

Review request : @Meinersbur @efriedma-quic @dcb314

Copy link
Collaborator

@efriedma-quic efriedma-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efriedma-quic efriedma-quic merged commit d33864d into llvm:main May 28, 2024
8 checks passed
@kartcq kartcq deleted the assert_fix branch May 29, 2024 03:56
vg0204 pushed a commit to vg0204/llvm-project that referenced this pull request May 29, 2024
This patch moves the unreachable assert before return statement.
Fixes llvm#91235.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polly/include/polly/ScheduleTreeTransform.h:52: assert in wrong place ?
2 participants