[flang] Fix build after #93226. #93516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The llvm#93226 adds 4 more fields in DICompositeTypeAttr. This PR provides default value of those 4 fields. This will be required to avoid build error once llvm#93226 is merged.
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-fir-hlfir Author: Abid Qadeer (abidh) ChangesThe #93226 adds 4 more fields in DICompositeTypeAttr. This PR provides default value of those 4 fields. This will be required to avoid build error once #93226 is merged. Full diff: https://github.com/llvm/llvm-project/pull/93516.diff 1 Files Affected:
diff --git a/flang/lib/Optimizer/Transforms/DebugTypeGenerator.cpp b/flang/lib/Optimizer/Transforms/DebugTypeGenerator.cpp
index 07163de958f91..a174f2c2bc4bf 100644
--- a/flang/lib/Optimizer/Transforms/DebugTypeGenerator.cpp
+++ b/flang/lib/Optimizer/Transforms/DebugTypeGenerator.cpp
@@ -73,7 +73,9 @@ mlir::LLVM::DITypeAttr DebugTypeGenerator::convertSequenceType(
context, llvm::dwarf::DW_TAG_array_type, /*recursive id*/ {},
/* name */ nullptr, /* file */ nullptr, /* line */ 0, /* scope */ nullptr,
elemTy, mlir::LLVM::DIFlags::Zero, /* sizeInBits */ 0,
- /*alignInBits*/ 0, elements);
+ /*alignInBits*/ 0, elements, /* dataLocation */ nullptr,
+ /* rank */ nullptr, /* allocated */ nullptr,
+ /* associated */ nullptr);
}
mlir::LLVM::DITypeAttr
|
abidh
added a commit
to abidh/llvm-project
that referenced
this pull request
May 28, 2024
The llvm#92568 introduced call of DICompositeTypeAttr::get in flang. This commit adjusts the call to fix the build. I initially opened the llvm#93516 for it but was advised to add this change in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #93226 adds 4 more fields in DICompositeTypeAttr. This PR provides default value of those 4 fields. This will be required to avoid build error once #93226 is merged.