Skip to content

[OMPT] Set default values for tsan function pointers #93568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2024

Conversation

FLZ101
Copy link
Contributor

@FLZ101 FLZ101 commented May 28, 2024

Avoid calling NULL function pointers in cases where ompt_start_tool succeeds but those tsan functions
do not really exist.

Fix #93524

@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels May 28, 2024
@FLZ101
Copy link
Contributor Author

FLZ101 commented May 28, 2024

@jprotze @nikic @vzakhari

Avoid calling NULL function pointers in cases where
ompt_start_tool succeeds but those tsan functions
do not really exist.
Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with two tweaks

@jprotze jprotze merged commit c09787b into llvm:main May 28, 2024
4 of 5 checks passed
vg0204 pushed a commit to vg0204/llvm-project that referenced this pull request May 29, 2024
Avoid calling NULL function pointers in cases where ompt_start_tool
succeeds but those tsan functions
do not really exist.

Fix llvm#93524

---------

Co-authored-by: Joachim <[email protected]>
@FLZ101 FLZ101 deleted the fix-ompt-tsan branch June 29, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OMPT] Segment fault caused by calling NULL tsan function pointers
3 participants