[llvm-objdump][test] Relax directory prefix check in source-interleave test

[nikic]

This test currently has an explicit regex for characters that are supposedly valid inside a directory name -- however, it does not actually cover all necessary characters. For example, this test fails if the path contains a tilde.

Instead, replace this with a wildcard.

[llvmbot]

@llvm/pr-subscribers-llvm-binary-utilities

Author: Nikita Popov (nikic)

Changes

This test currently has an explicit regex for characters that are supposedly valid inside a directory name -- however, it does not actually cover all necessary characters. For example, this test fails if the path contains a tilde.

Instead, replace this with a wildcard.

---

Full diff: https://github.com/llvm/llvm-project/pull/93789.diff

1 Files Affected:

• (modified) llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test (+1-1)

diff --git a/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test b/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
index cbcc35cf79653..dcce95c83b1d2 100644
--- a/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
+++ b/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
@@ -11,7 +11,7 @@
 
 # LINES: <main>:
 # LINES-NEXT: ; main():
-# LINES-NEXT: ; {{[ -\(\)_A-Za-z0-9.\\/:]+}}source-interleave-x86_64.c:6
+# LINES-NEXT: ; {{.+}}source-interleave-x86_64.c:6
 
 # SOURCE: <main>:
 # SOURCE-NEXT: ; int main() {

[MaskRay]

(NFC)

This is good, but I think [test] is more popular for pure test changes. NFC can describe code changes, while [test] is clear it is for tests.

[jh7370]

FWIW, I think this should probably actually be using a FileCheck variable, defined on the command-line using a lit substitution (e.g. FileCheck -D SRC_DIR=%S ... and here ; [[SRC_DIR]]source-interleave-x86_64.c:6 - just an example, the actual variable probably wants to be something else).