[MLIR][NVVM] Make the call to findTool optional for fatbinary #93968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fatbinary tool is only needed when the fatbinary format is requested. The current code is especially confusing in that it emits an error complaining that fatbinary has not been found even though it's not even used (and the serialization succeeds nevertheless...).
|
@llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-mlir Author: Adam Paszke (apaszke) ChangesThe fatbinary tool is only needed when the fatbinary format is requested. The current code is especially confusing in that it emits an error complaining that fatbinary has not been found even though it's not even used (and the serialization succeeds nevertheless...). Full diff: https://github.com/llvm/llvm-project/pull/93968.diff 1 Files Affected:
diff --git a/mlir/lib/Target/LLVM/NVVM/Target.cpp b/mlir/lib/Target/LLVM/NVVM/Target.cpp
index e75547ff9b850..acb903aa37caf 100644
--- a/mlir/lib/Target/LLVM/NVVM/Target.cpp
+++ b/mlir/lib/Target/LLVM/NVVM/Target.cpp
@@ -267,9 +267,12 @@ NVPTXSerializer::compileToBinary(const std::string &ptxCode) {
std::optional<std::string> ptxasCompiler = findTool("ptxas");
if (!ptxasCompiler)
return std::nullopt;
- std::optional<std::string> fatbinaryTool = findTool("fatbinary");
- if (createFatbin && !fatbinaryTool)
- return std::nullopt;
+ std::optional<std::string> fatbinaryTool;
+ if (createFatbin) {
+ fatbinaryTool = findTool("fatbinary");
+ if (!fatbinaryTool)
+ return std::nullopt;
+ }
Location loc = getOperation().getLoc();
// Base name for all temp files: mlir-<module name>-<target triple>-<chip>.
|
|
Looks good to me. Let's also check with @fabianmcg |
grypp
approved these changes
May 31, 2024
|
Took another look, the change is actually trivial. So I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fatbinary tool is only needed when the fatbinary format is requested.
The current code is especially confusing in that it emits an error complaining that fatbinary has not been found even though it's not even used (and the serialization succeeds nevertheless...).