-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Re-merge A few updates around "transcript"
(#92843)
#94067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @clayborg to look at this fix |
clayborg
reviewed
May 31, 2024
lldb/test/API/python_api/interpreter/TestCommandInterpreterAPI.py
Outdated
Show resolved
Hide resolved
FWIW, it may be easier to see the fix this way. <-- This is the delta between |
A few updates around "transcript"
#92843
A few updates around "transcript"
#92843A few updates around "transcript"
(#92843)
clayborg
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problematic PR: #92843
Reverted by: #94088
The first PR added a test which fails in Linux builds (see the last few comments there).
This PR contains all the changes in the first PR, plus the fix to the said test.