Skip to content

Re-merge A few updates around "transcript" (#92843) #94067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

royitaqi
Copy link
Contributor

@royitaqi royitaqi commented May 31, 2024

Problematic PR: #92843
Reverted by: #94088

The first PR added a test which fails in Linux builds (see the last few comments there).
This PR contains all the changes in the first PR, plus the fix to the said test.

@royitaqi
Copy link
Contributor Author

royitaqi commented May 31, 2024

cc @clayborg to look at this fix

@royitaqi
Copy link
Contributor Author

royitaqi commented May 31, 2024

FWIW, it may be easier to see the fix this way. <-- This is the delta between royitaqi:enhance-transcript-3 (the fix) and royitaqi:enhance-transcript-2 (the merged PR that caused the test failure).

@royitaqi royitaqi changed the title Fix a test failure in PR #92843 Re-merge A few updates around "transcript" #92843 Jun 3, 2024
@royitaqi royitaqi changed the title Re-merge A few updates around "transcript" #92843 Re-merge A few updates around "transcript" (#92843) Jun 3, 2024
@clayborg clayborg merged commit c2d061d into llvm:main Jun 3, 2024
4 checks passed
@royitaqi royitaqi deleted the enhance-transcript-3 branch October 24, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants