Fix detection of __datasizeof with Clang. #94174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `__has_extension` builtin macro is the same as __has_feature when -pedantic-errors is specified, which means we don't get the right information about __datasizeof being available. Using __has_keyword (really !__is_identifier) will tell the truth even when -pedantic-errors is specified. This means we always have __datasizeof under Clang
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Eric (EricWF) ChangesThe Using __has_keyword (really !__is_identifier) will tell the truth This means we always have __datasizeof under Clang Full diff: https://github.com/llvm/llvm-project/pull/94174.diff 1 Files Affected:
diff --git a/libcxx/include/__type_traits/datasizeof.h b/libcxx/include/__type_traits/datasizeof.h
index 54fde242ebcde..35c12921e8ffa 100644
--- a/libcxx/include/__type_traits/datasizeof.h
+++ b/libcxx/include/__type_traits/datasizeof.h
@@ -26,7 +26,7 @@
_LIBCPP_BEGIN_NAMESPACE_STD
-#if __has_extension(datasizeof)
+#if __has_keyword(__datasizeof) || __has_extension(datasizeof)
template <class _Tp>
inline const size_t __datasizeof_v = __datasizeof(_Tp);
#else
|
ldionne
approved these changes
Jun 5, 2024
|
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__has_extensionbuiltin macro is the same as __has_feature when-pedantic-errors is specified, which means we don't get the right
information about __datasizeof being available.
Using __has_keyword (really !__is_identifier) will tell the truth
even when -pedantic-errors is specified.
This means we always have __datasizeof under Clang