[LLVM] Fix runtimes builds not triggering without LLVM_ENABLE_RUNTIMES #94225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The runtimes builds create separate projects. Normally these use `LLVM_EANBLE_RUNTIMES`. However, we can also use `LLVM_RUNTIME_TARGETS` and `RUNTIMES_<target>_LLVM_ENABLE_RUNTIMES` to enable them. Currently, if `LLVM_RUNTIME_TARGETS` isn't specified this is completely ignored. This patch fixes the behavior so we can only specify the cross-compiling versions.
petrhosek
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The runtimes builds create separate projects. Normally these use
LLVM_EANBLE_RUNTIMES. However, we can also useLLVM_RUNTIME_TARGETSand
RUNTIMES_<target>_LLVM_ENABLE_RUNTIMESto enable them. Currently,if
LLVM_RUNTIME_TARGETSisn't specified this is completely ignored.This patch fixes the behavior so we can only specify the cross-compiling
versions.