Skip to content

Fix lsda-section-name adding back RUN line incorrectly removed in 6ef632ad36c522b0 #94301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

joker-eph
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jun 4, 2024

@llvm/pr-subscribers-bolt

Author: Mehdi Amini (joker-eph)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/94301.diff

1 Files Affected:

  • (modified) bolt/test/lsda-section-name.cpp (+1)
diff --git a/bolt/test/lsda-section-name.cpp b/bolt/test/lsda-section-name.cpp
index 34a736f816264..929b17f3b63d4 100644
--- a/bolt/test/lsda-section-name.cpp
+++ b/bolt/test/lsda-section-name.cpp
@@ -1,6 +1,7 @@
 // This test check that LSDA section named by .gcc_except_table.main is
 // disassembled by BOLT.
 
+// RUN: %clang++ %cxxflags -O3 -no-pie -c %s -o %t.o
 // RUN: %clang++ %cxxflags -O3 -no-pie -fuse-ld=lld %t.o -o %t
 // RUN: llvm-objcopy --rename-section .gcc_except_table=.gcc_except_table.main %t
 // RUN: llvm-readelf -SW %t | FileCheck %s

@dcci
Copy link
Member

dcci commented Jun 4, 2024

Thank you Mehdi.

Copy link

github-actions bot commented Jun 4, 2024

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 9b0e1c2ca25be58ea29b318d3515e6171f25f0ea ac7288e0bbdad7d6cb5dd568169afcf4987e1fa1 -- bolt/test/lsda-section-name.cpp
View the diff from clang-format here.
diff --git a/bolt/test/lsda-section-name.cpp b/bolt/test/lsda-section-name.cpp
index 929b17f3b6..e3db4cc4ce 100644
--- a/bolt/test/lsda-section-name.cpp
+++ b/bolt/test/lsda-section-name.cpp
@@ -3,9 +3,8 @@
 
 // RUN: %clang++ %cxxflags -O3 -no-pie -c %s -o %t.o
 // RUN: %clang++ %cxxflags -O3 -no-pie -fuse-ld=lld %t.o -o %t
-// RUN: llvm-objcopy --rename-section .gcc_except_table=.gcc_except_table.main %t
-// RUN: llvm-readelf -SW %t | FileCheck %s
-// RUN: llvm-bolt %t -o %t.bolt
+// RUN: llvm-objcopy --rename-section .gcc_except_table=.gcc_except_table.main
+// %t RUN: llvm-readelf -SW %t | FileCheck %s RUN: llvm-bolt %t -o %t.bolt
 
 // CHECK: .gcc_except_table.main
 

@joker-eph joker-eph merged commit c7b7875 into llvm:main Jun 4, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants