Skip to content

[libc][test] Fix TEST->TEST_F typo in getenv_and_setenv_test.cpp #94304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

rupprecht
Copy link
Collaborator

This manifests as AddressSanitizer: stack-use-after-return w/o this change. The ~CheckFEnv() method of checking fenv seems to only work for test fixtures.

This manifests as `AddressSanitizer: stack-use-after-return` w/o this change. The `~CheckFEnv()` method of checking fenv seems to only work for test fixtures.
@llvmbot llvmbot added the libc label Jun 4, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 4, 2024

@llvm/pr-subscribers-libc

Author: Jordan Rupprecht (rupprecht)

Changes

This manifests as AddressSanitizer: stack-use-after-return w/o this change. The ~CheckFEnv() method of checking fenv seems to only work for test fixtures.


Full diff: https://github.com/llvm/llvm-project/pull/94304.diff

1 Files Affected:

  • (modified) libc/test/src/fenv/getenv_and_setenv_test.cpp (+1-1)
diff --git a/libc/test/src/fenv/getenv_and_setenv_test.cpp b/libc/test/src/fenv/getenv_and_setenv_test.cpp
index 7257e75cb421a..8fc2787ecb5b1 100644
--- a/libc/test/src/fenv/getenv_and_setenv_test.cpp
+++ b/libc/test/src/fenv/getenv_and_setenv_test.cpp
@@ -41,7 +41,7 @@ TEST_F(LlvmLibcFEnvTest, GetEnvAndSetEnv) {
   }
 }
 
-TEST(LlvmLibcFenvTest, Set_FE_DFL_ENV) {
+TEST_F(LlvmLibcFEnvTest, Set_FE_DFL_ENV) {
   // We will disable all exceptions to prevent invocation of the exception
   // handler.
   LIBC_NAMESPACE::fputil::disable_except(FE_ALL_EXCEPT);

@rupprecht rupprecht merged commit 392ca64 into llvm:main Jun 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants