Skip to content

[bazel] Port #94218 #94390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[bazel] Port #94218 #94390

merged 1 commit into from
Jun 4, 2024

Conversation

keith
Copy link
Member

@keith keith commented Jun 4, 2024

No description provided.

@keith keith requested a review from rupprecht as a code owner June 4, 2024 19:45
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Jun 4, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 4, 2024

@llvm/pr-subscribers-libc

Author: Keith Smiley (keith)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/94390.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl (+1)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl b/utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl
index da4964bd89824..11d2e5aa340f6 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl
@@ -25,6 +25,7 @@ def math_test(name, hdrs = [], deps = [], **kwargs):
         srcs = [test_name + ".cpp"] + hdrs,
         libc_function_deps = ["//libc:func_name".replace("func_name", name)],
         deps = [
+            "//libc:__support_cpp_algorithm",
             "//libc:__support_fputil_basic_operations",
             "//libc:__support_fputil_fenv_impl",
             "//libc:__support_fputil_fp_bits",

@keith keith merged commit 3b2df5b into llvm:main Jun 4, 2024
8 checks passed
@keith keith deleted the ks/bazel-port-94218 branch June 4, 2024 19:48
@michaelrj-google
Copy link
Contributor

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants